Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FileCache#Find] N to 1 calls for file matching #14351

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

[FileCache#Find] N to 1 calls for file matching #14351

wants to merge 5 commits into from

Commits on May 17, 2024

  1. [FileCache#find] Add additional tests 

    Signed-off-by: David Crosby <dcrosby@fb.com>
    @dafyddcrosby
    dafyddcrosby committed May 17, 2024
    Configuration menu
    Copy the full SHA
    7842eae View commit details
    Browse the repository at this point in the history

Commits on May 21, 2024

  1. [FileCache#find] Refactor file_cache_path 

    Signed-off-by: David Crosby <dcrosby@fb.com>
    @dafyddcrosby
    dafyddcrosby committed May 21, 2024
    Configuration menu
    Copy the full SHA
    8a5b1e5 View commit details
    Browse the repository at this point in the history

  2. [FileCache#find] Switch to easier-to-GC loop 

    Instead of holding the reference to files the whole loop, use until and take
the head from the array

Signed-off-by: David Crosby <dcrosby@fb.com>
    @dafyddcrosby
    dafyddcrosby committed May 21, 2024
    Configuration menu
    Copy the full SHA
    8ea49d4 View commit details
    Browse the repository at this point in the history

  3. [FileCache#find] Refactor first_filename 

    Signed-off-by: David Crosby <dcrosby@fb.com>
    @dafyddcrosby
    dafyddcrosby committed May 21, 2024
    Configuration menu
    Copy the full SHA
    6dc4837 View commit details
    Browse the repository at this point in the history

  4. [FileCache#find] N to 1 calls for regex matching 

    The regular expression's capture is changed so that instead of capturing the
tail of the file string (ie cache path excluded), we capture the cache path
instead so that we can use delete_prefix calls to mutate the strings directly,
saving on allocations

Signed-off-by: David Crosby <dcrosby@fb.com>
    @dafyddcrosby
    dafyddcrosby committed May 21, 2024
    Configuration menu
    Copy the full SHA
    7f821bb View commit details
    Browse the repository at this point in the history