Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use versionfile for mill #3990

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

use versionfile for mill #3990

wants to merge 1 commit into from

Conversation

sequencer
Copy link
Member

Reference: https://mill-build.com/mill/contrib/versionfile.html

This provide a unified version management target for future releasing.

After switch to mill, I'd like to store all dependency versions to version folder for reference, CI bump and review.

Contributor Checklist

  • Did you add Scaladoc to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you add appropriate documentation in docs/src?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • Feature (or new API)
  • API modification
  • API deprecation
  • Backend code generation
  • Performance improvement
  • Bugfix
  • Documentation or website-related
  • Dependency update
  • Internal or build-related (includes code refactoring/cleanup)

Desired Merge Strategy

  • Squash: The PR will be squashed and merged (choose this if you have no preference).
  • Rebase: You will rebase the PR onto master and it will be merged with a merge commit.

Release Notes

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels? (Select the most appropriate one based on the "Type of Improvement")
  • Did you mark the proper milestone (Bug fix: 3.6.x, 5.x, or 6.x depending on impact, API modification or big change: 7.0)?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you do one of the following when ready to merge:
    • Squash: You/ the contributor Enable auto-merge (squash), clean up the commit message, and label with Please Merge.
    • Merge: Ensure that contributor has cleaned up their commit history, then merge with Create a merge commit.

@jackkoenig
Copy link
Contributor

With the current SBT flow, every push to main publishes a SNAPSHOT based on the current commit. That wouldn't work with a version file.

Similarly, the current flow for tagged releases uses the git tag as the version. We could use a version file but that would require making an extra commit for every release that isn't needed in the current flow.

@sequencer
Copy link
Member Author

With the current SBT flow, every push to main publishes a SNAPSHOT based on the current commit. That wouldn't work with a version file.
Similarly, the current flow for tagged releases uses the git tag as the version. We could use a version file but that would require making an extra commit for every release that isn't needed in the current flow.

Yes, we should dig out a way to maintain version in mill, this is just an example, we can override functions in the VersionFileModule trait, or even get rid of it. This is just for discussion.

@sequencer sequencer marked this pull request as draft April 11, 2024 22:31
@sequencer sequencer added No Release Notes Exclude from release notes, consider using Internal instead Internal Internal change, does not affect users, will be included in release notes labels Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Internal Internal change, does not affect users, will be included in release notes No Release Notes Exclude from release notes, consider using Internal instead
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants