Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add FixedIOIntrinsicModuleGenerator for linking procedure #3999

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

sequencer
Copy link
Member

@sequencer sequencer commented Apr 16, 2024

TL;DL

This is designed for chisel linking flow.

  • Chisel doesn't need to import mlirbc, but need to expose a linkable module to be FixedIOIntrinsicModuleGenerator.
  • FixedIOIntrinsicModuleGenerator contains the metadata on the IO type and the metadata of SerializableModuleGenerator a main class will be used for auto gen.
  • CIRCT should resolve all FixedIOIntrinsicModuleGenerator at the very first stage and elaborate them in parallel(this may even speed up the elaboration flow, since it can be parallelized).
  • CIRCT should check the interface after for each elaboration.
  • CIRCT should be able to control the lowering option, e.g. classpath of generator.

Contributor Checklist

  • Did you add Scaladoc to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you add appropriate documentation in docs/src?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • Feature (or new API)
  • API modification
  • API deprecation
  • Backend code generation
  • Performance improvement
  • Bugfix
  • Documentation or website-related
  • Dependency update
  • Internal or build-related (includes code refactoring/cleanup)

Desired Merge Strategy

  • Squash: The PR will be squashed and merged (choose this if you have no preference).
  • Rebase: You will rebase the PR onto master and it will be merged with a merge commit.

Release Notes

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels? (Select the most appropriate one based on the "Type of Improvement")
  • Did you mark the proper milestone (Bug fix: 3.6.x, 5.x, or 6.x depending on impact, API modification or big change: 7.0)?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you do one of the following when ready to merge:
    • Squash: You/ the contributor Enable auto-merge (squash), clean up the commit message, and label with Please Merge.
    • Merge: Ensure that contributor has cleaned up their commit history, then merge with Create a merge commit.

@sequencer sequencer assigned azidar and unassigned azidar Apr 16, 2024
@sequencer sequencer requested a review from azidar April 17, 2024 01:44
@sequencer sequencer force-pushed the declaration-implementation-linking branch from 65023fa to 90b7d28 Compare April 21, 2024 00:55
@sequencer sequencer force-pushed the declaration-implementation-linking branch from 90b7d28 to 44e8423 Compare April 21, 2024 01:03
@sequencer sequencer changed the title HWCallOutIntrinsic for linking add FixedIOIntrinsicModuleGenerator for linking procedure Apr 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants