Improve source locators for intrinsic helpers.

[dtzSiFive]

Better to point to where the intrinsic was used,
not where the wrapper is defined.

Contributor Checklist

• Did you add Scaladoc to every public function/method?
• Did you add at least one test demonstrating the PR?
• Did you delete any extraneous printlns/debugging code?
• Did you specify the type of improvement?
• Did you add appropriate documentation in docs/src?
• Did you request a desired merge strategy?
• Did you add text to be included in the Release Notes for this change?

Type of Improvement

• Backend code generation

Desired Merge Strategy

• Squash: The PR will be squashed and merged (choose this if you have no preference).

Release Notes

Use source information where intrinsic wrapper is used, instead of location of the wrapper's implementation.

Reviewer Checklist (only modified by reviewer)

• Did you add the appropriate labels? (Select the most appropriate one based on the "Type of Improvement")
• Did you mark the proper milestone (Bug fix: 3.6.x, 5.x, or 6.x depending on impact, API modification or big change: 7.0)?
• Did you review?
• Did you check whether all relevant Contributor checkboxes have been checked?
• Did you do one of the following when ready to merge:
  • Squash: You/ the contributor Enable auto-merge (squash), clean up the commit message, and label with Please Merge.
  • Merge: Ensure that contributor has cleaned up their commit history, then merge with Create a merge commit.

[jackkoenig]

I hate to have to point out (because the fix is a little annoying), but this is a source incompatible change. If a user were doing PlusArgsValue(UInt(8.W), "whatever")(7) to take just the 7th bit of the value, the code will no longer compile. This is the whole do_apply pattern. Naturally this is fixed in Scala 3, at the moment we have to do the macro.

[dtzSiFive]

I'll take a look at that, thanks, that totally makes sense.

[dtzSiFive]

Not sure when will get to pushing on this, closing for now 👍.