Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support custom type attribute in scriptLoader method with new parameter T/5434 #5435

Closed
wants to merge 3 commits into from
Closed

Support custom type attribute in scriptLoader method with new parameter T/5434 #5435

wants to merge 3 commits into from

Commits on Feb 23, 2023

  1. Add typeAttribute parameter to scriptloader.js load method. 

    Support custom type attributes on the rendered script tag using a new typeAttribute parameter that defaults to 'text/javascript'.
    @matthandus
    matthandus committed Feb 23, 2023
    Configuration menu
    Copy the full SHA
    7e3dfdf View commit details
    Browse the repository at this point in the history

  2. Add custom attribute test to tests/core/scriptloader.js. 

    Test that the new custom type attribute is detected using the new typeAttribute parameter on the scriptLoader.load method.
    @matthandus
    matthandus committed Feb 23, 2023
    Configuration menu
    Copy the full SHA
    44e039a View commit details
    Browse the repository at this point in the history

  3. Fix findOne selector.

    @matthandus
    matthandus committed Feb 23, 2023
    Configuration menu
    Copy the full SHA
    bdee318 View commit details
    Browse the repository at this point in the history