Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use pointer instead of long, which won't work on Windows #237

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

eat-swap
Copy link

Using sizeof(long) == 4 to tell whether a platform is 32-bit or not is not reliable since LLP64 platforms exists (and specifically, Win64 API, refernece here). This causes problems while trying to port lrzip to such platfroms.

@anon767
Copy link

anon767 commented Jan 16, 2023

wouldn't be sizeof(size_t) == 4 be more appropriate?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants