Skip to content
This repository has been archived by the owner on May 6, 2020. It is now read-only.

build: configuration file depends on build variables #374

Merged
merged 1 commit into from Aug 7, 2017
Merged

build: configuration file depends on build variables #374

merged 1 commit into from Aug 7, 2017

Conversation

wcwxyz
Copy link
Contributor

@wcwxyz wcwxyz commented Jul 31, 2017

Build variables will affect configuration file.

Fixes #285

Signed-off-by: WANG Chao chao.wang@ucloud.cn

@wcwxyz
build: configuration file depends on build variables
2c456d7 
Build variables will affect configuration file.

Fixes #285

Signed-off-by: WANG Chao <chao.wang@ucloud.cn>
@coveralls
Copy link

coveralls commented Jul 31, 2017 •
edited

Coverage Status

Coverage remained the same at 53.451% when pulling 2c456d7 on wcwxyz:fix-configuration-file-generation into df043b1 on clearcontainers:master.

@sboeuf
Copy link
Contributor

sboeuf commented Jul 31, 2017 •
edited by dlespiau

LGTM

Approved with PullApprove

@jodh-intel
Copy link
Contributor

jodh-intel commented Aug 7, 2017 •
edited by dlespiau

lgtm

Approved with PullApprove Approved with PullApprove

@jodh-intel jodh-intel merged commit bcfc581 into clearcontainers:master Aug 7, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@wcwxyz @coveralls @sboeuf @jodh-intel