-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: obtain repository from filepath within git repository #71
base: master
Are you sure you want to change the base?
Conversation
explain what the ceiling directories were
Resolves #70 |
Thanks for the swift PR! I was thinking to change If we go with Maybe other users want to chime in with some feedback. /cc @jaromil |
Ah, this makes much more sense. I will modify the function for now to reflect that. If that's the case, do you think the name of the function should be changed as well? |
Function now returns the git directory path, instead of a Repository object.
955a80e
to
ab8689c
Compare
Adds functionality to obtain a
Repository
object given a file anywhere within a Git repository. Includes support foraddCeilingDirectories
and would be used like so (as an example):Usage without ceiling directories
Usage with ceiling directories