Check array indicies are set before using #278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix errors reported by PHP 7.4: - Trying to access array offset on value of type null in [/path/to]/wp-content/plugins/cloudflare/src/WordPress/Proxy.php on line 62 - Undefined offset: 0 in [/path/to]/wp-content/plugins/cloudflare/src/WordPress/ClientActions.php on line 87 The first error repeats on plugin settings page views. The second error occurs on initial activation of plugin.
|
These are the only errors found in my logs with PHP 7.4.3 and WordPress 5.5.1 on Ubuntu 20.04 running nginx 1.18.0. Plugin seems to work correctly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix errors reported by PHP 7.4:
The first error repeats on plugin settings page views. The second error
occurs on initial activation of plugin.
Fixes https://wordpress.org/support/topic/no-support-for-php-7-4-and-newest-wordpress/
Fixes #271
Fixes #274