Add focusAfterToggle:boolean option to focus element after toggle #56
Conversation
hideShowPassword.js
Outdated
| // the element has been toggled. Benefitial for those who are | ||
| // typing out a password and just want to check their value | ||
| // and retain the focus of the input. | ||
| focusAfterToggle: false, |
There was a problem hiding this comment.
For consistency with the innerToggle option and for flexibility, should this instead be something like triggerOnToggle where you could provide an event name? For example, triggerOnToggle: 'focus' or triggerOnToggle: 'focus.my-focus-event'?
There was a problem hiding this comment.
@tylersticka I updated the PR using the triggerOnToggle syntax like you recommended to maintain consistency.
hideShowPassword.js
Outdated
| // Event to trigger whenever the element is toggled. | ||
| // For example, if 'focus' it will focus the cursor in the | ||
| // input element after toggling. | ||
| triggerOnToggle: '', |
There was a problem hiding this comment.
Do you think this should still default to false? I know it means a conditional check later, but I don't know what the performance of running a needless trigger method is compared to checking for it first.
There was a problem hiding this comment.
Updated PR with a default triggerOnToggle: false and a boolean check before calling the event. I'm not 100% sure on the performance either, but I assume that a boolean check is cheaper than an empty event call.
|
@dlegr250 Thank you for making those changes! I'll merge this once I have some time to minify, version-bump and publish. |
|
@dlegr250 Thanks again, available in |
Awesome plugin, saved me from having to write my own!
I think most users will be focused in the text/password field entering input when they toggle the show/hide; I think it would be a good idea to allow an option to retain focus on the input element after toggling.
Default behavior does not change anything, must set the option in order for any effect to occur.
Did not update any version/scripts in case you all had a specific way you wanted to bump those.