-
Notifications
You must be signed in to change notification settings - Fork 256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: use global registry env variables #4538
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
backport-requested ◀️
This pull request should be backported to all supported releases
release-1.21
release-1.22
release-1.23
labels
May 15, 2024
❗ By default, the pull request is configured to backport to all release branches.
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
NiccoloFei
force-pushed
the
dev/fix-ci-vars
branch
2 times, most recently
from
May 15, 2024 13:54
e0231f0
to
84e7730
Compare
sxd
approved these changes
May 15, 2024
/test limit=local depth=push test_level=1 feature_type=basic |
@sxd, here's the link to the E2E on CNPG workflow run: https://github.com/cloudnative-pg/cloudnative-pg/actions/runs/9099736679 |
NiccoloFei
force-pushed
the
dev/fix-ci-vars
branch
from
May 17, 2024 16:04
84e7730
to
01425de
Compare
NiccoloFei
force-pushed
the
dev/fix-ci-vars
branch
from
May 20, 2024 10:06
01425de
to
a6da7e6
Compare
leonardoce
approved these changes
May 21, 2024
NiccoloFei
force-pushed
the
dev/fix-ci-vars
branch
4 times, most recently
from
May 28, 2024 09:47
756124e
to
5a2e9c8
Compare
jsilvela
approved these changes
May 29, 2024
litaocdl
approved these changes
May 30, 2024
Signed-off-by: Niccolò Fei <niccolo.fei@enterprisedb.com>
Signed-off-by: Niccolò Fei <niccolo.fei@enterprisedb.com>
Signed-off-by: Tao Li <tao.li@enterprisedb.com>
/ok-to-merge |
cnpg-bot
pushed a commit
that referenced
this pull request
May 30, 2024
Use the globally instantiated env variables when possible, instead of hardcoding the values. Signed-off-by: Niccolò Fei <niccolo.fei@enterprisedb.com> Signed-off-by: Tao Li <tao.li@enterprisedb.com> Co-authored-by: Tao Li <tao.li@enterprisedb.com> (cherry picked from commit f0e3fdb)
cnpg-bot
pushed a commit
that referenced
this pull request
May 30, 2024
Use the globally instantiated env variables when possible, instead of hardcoding the values. Signed-off-by: Niccolò Fei <niccolo.fei@enterprisedb.com> Signed-off-by: Tao Li <tao.li@enterprisedb.com> Co-authored-by: Tao Li <tao.li@enterprisedb.com> (cherry picked from commit f0e3fdb)
cnpg-bot
pushed a commit
that referenced
this pull request
May 30, 2024
Use the globally instantiated env variables when possible, instead of hardcoding the values. Signed-off-by: Niccolò Fei <niccolo.fei@enterprisedb.com> Signed-off-by: Tao Li <tao.li@enterprisedb.com> Co-authored-by: Tao Li <tao.li@enterprisedb.com> (cherry picked from commit f0e3fdb)
dougkirkley
pushed a commit
to dougkirkley/cloudnative-pg
that referenced
this pull request
Jun 11, 2024
Use the globally instantiated env variables when possible, instead of hardcoding the values. Signed-off-by: Niccolò Fei <niccolo.fei@enterprisedb.com> Signed-off-by: Tao Li <tao.li@enterprisedb.com> Co-authored-by: Tao Li <tao.li@enterprisedb.com> Signed-off-by: Douglass Kirkley <dkirkley@eitccorp.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport-requested ◀️
This pull request should be backported to all supported releases
no-issue
ok to merge 👌
This PR can be merged
release-1.21
release-1.22
release-1.23
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's use the globally instantiated env variables when possible instead of hardcoding the values.