You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This issue was in the code already, but this parameter should be tracked (impacts physics). Could edm::InputTag parameter type be used directly? Also, is the nested AlcaPCCIntegratorParameters really necessary? It doesn't seem to provide any value here (but I may be missing something).
Also, if the thePCCInputTag_ is only used as an argument for consumes(), it does not have to be a member variable of the class (causing minuscule memory increase throughout the job).
Discussed here
https://github.com/cms-sw/cmssw/pull/37538/files#r848720360
This issue was in the code already, but this parameter should be tracked (impacts physics). Could edm::InputTag parameter type be used directly? Also, is the nested AlcaPCCIntegratorParameters really necessary? It doesn't seem to provide any value here (but I may be missing something).
Also, if the thePCCInputTag_ is only used as an argument for consumes(), it does not have to be a member variable of the class (causing minuscule memory increase throughout the job).
https://github.com/cms-sw/cmssw/blob/78daa840cbdb6216bcca00a73004a764a8edd8d9/Calibration/LumiAlCaRecoProducers/plugins/AlcaPCCIntegrator.cc#L56-L62
The text was updated successfully, but these errors were encountered: