Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change AlcaPCCIntegrator params to traced #61

Closed
tvami opened this issue Apr 29, 2022 · 1 comment · Fixed by cms-sw/cmssw#38077
Closed

Change AlcaPCCIntegrator params to traced #61

tvami opened this issue Apr 29, 2022 · 1 comment · Fixed by cms-sw/cmssw#38077

Comments

@tvami
Copy link
Contributor

tvami commented Apr 29, 2022

Discussed here
https://github.com/cms-sw/cmssw/pull/37538/files#r848720360

This issue was in the code already, but this parameter should be tracked (impacts physics). Could edm::InputTag parameter type be used directly? Also, is the nested AlcaPCCIntegratorParameters really necessary? It doesn't seem to provide any value here (but I may be missing something).

Also, if the thePCCInputTag_ is only used as an argument for consumes(), it does not have to be a member variable of the class (causing minuscule memory increase throughout the job).

https://github.com/cms-sw/cmssw/blob/78daa840cbdb6216bcca00a73004a764a8edd8d9/Calibration/LumiAlCaRecoProducers/plugins/AlcaPCCIntegrator.cc#L56-L62

@tvami
Copy link
Contributor Author

tvami commented May 25, 2022

Resolved in cms-sw/cmssw#38077

@tvami tvami closed this as completed May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging a pull request may close this issue.

1 participant