Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DQMOnlineBeamspot streamer files for run 356383 #2

Merged
merged 1 commit into from Aug 7, 2022

Conversation

francescobrivio
Copy link
Contributor

Title says it all.
This is needed in order to update the CMSSW DQM beamhlt client unitTest now that we have a "final" event-content of the streamer files.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 1, 2022

A new Pull Request was created by @francescobrivio for branch main.

@smuzaffar, @aandvalenzuela, @emanueleusai, @iarspider, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks.
@threus, @batinkov, @battibass this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy, @rappoccio you are the release manager for this.
cms-bot commands are listed here

@francescobrivio
Copy link
Contributor Author

Tests in the CMSSW PR run fine (see cms-sw/cmssw#38925 (comment)), so can we merge this @qliphy @perrotta @rappoccio? Thanks!

@qliphy
Copy link
Contributor

qliphy commented Aug 7, 2022

+1

@qliphy
Copy link
Contributor

qliphy commented Aug 7, 2022

merge
tested and signed in cms-sw/cmssw#38925

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 7, 2022

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f215ba/26681/summary.html
COMMIT: dfb9fa7
CMSSW: CMSSW_12_5_X_2022-08-06-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-data/DQM-Integration/2/26681/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found errors in the following unit tests:

---> test TestDQMOnlineClient-l1tstage2_dqm_sourceclient had ERRORS
---> test TestDQMOnlineClient-l1tstage2emulator_dqm_sourceclient had ERRORS

Comparison Summary

Summary:

  • No significant changes to the logs found
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 30 differences found in the comparisons
  • DQMHistoTests: Total files compared: 51
  • DQMHistoTests: Total histograms compared: 3691612
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3691588
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
  • Checked 212 log files, 49 edm output root files, 51 DQM output files
  • TriggerResults: no differences found

@qliphy
Copy link
Contributor

qliphy commented Aug 7, 2022

@francescobrivio Is the unit test failure temporary?

---> test testSerializationSiPixelObjects succeeded
TestTime:1
^^^^ End Test testSerializationSiPixelObjects ^^^^
Package DQM/Integration: Running test TestDQMOnlineClient-hcal_dqm_sourceclient

===== Test "ppsTrackBasedAligAnalRes" ====
r_actual_file: ./cumulative_factored_results_Jan.xml
r_ideal_file: ./cumulative_factored_results_Ideal.xml
s_actual_file: ./cumulative_expanded_results_Jan.xml
s_ideal_file: ./cumulative_expanded_results_Ideal.xml
ERROR: A std::exception has been caught:
basic_string::replace: __pos (which is 18446744073709551615) > this->size() (which is 6)
Stopping.

@qliphy
Copy link
Contributor

qliphy commented Aug 7, 2022

===== Test "TestDQMOnlineClient-l1tstage2_dqm_sourceclient" ====

  • [[ 1 -eq 0 ]]
  • [[ -z '' ]]
  • LOCAL_TEST_DIR=.
  • [[ -z '' ]]
  • CLIENTS_DIR=./src/DQM/Integration/python/clients
  • mkdir -p ./upload
  • cmsRun ./src/DQM/Integration/python/clients/l1tstage2_dqm_sourceclient-live_cfg.py unitTest=True
    ----- Begin Fatal Exception 07-Aug-2022 04:17:23 CEST-----------------------
    An exception of category 'ConfigFileReadError' occurred while
    [0] Processing the python configuration file named ./src/DQM/Integration/python/clients/l1tstage2_dqm_sourceclient-live_cfg.py
    Exception Message:
    unknown python problem occurred.
    AttributeError: 'Process' object has no attribute 'totemTriggerRawToDigi'

At:
./src/DQM/Integration/python/clients/l1tstage2_dqm_sourceclient-live_cfg.py(66):

@francescobrivio francescobrivio deleted the add_newDQMstreamers branch August 29, 2022 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants