Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced training .xml files with new trainings for 80X release #2

Merged
1 commit merged into from Jan 25, 2016

Conversation

smoortga
Copy link
Contributor

Replaced .xml files of the CTagger retrainings for the 80X release.
This PR comes together with the following changes in RecoBTag/CTagging/python/training_settings.py from the following PR: cms-sw/cmssw#13054

@mverzett

@cmsbuild
Copy link

A new Pull Request was created by @smoortga for branch master.

@cmsbuild, @smuzaffar, @Degano, @iahmad-khan, @davidlange6 can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

external issue cms-sw/cmsdist#2086

ghost pushed a commit that referenced this pull request Jan 25, 2016
Replaced training .xml files with new trainings for 80X release
@ghost ghost merged commit 7a5db41 into cms-data:master Jan 25, 2016
@slava77
Copy link

slava77 commented Jan 25, 2016

From cms-sw/cmssw#13054, it looks like the variables have changed.
So, the old code will not run on the new input files.

I would like to ask to revert this PR merge and get a new PR where the new xml file names with the new training are introduced.
This way we can get a working IB with the new files first and then can independently test the cmssw PR.

@ghost
Copy link

ghost commented Jan 25, 2016

@slava77 okay, sorry. I'm reverting it asap. The CMSDIST test cms-sw/cmsdist#2087 will still complete.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants