Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New DeepFlavour training on 10X MC #14

Merged
merged 2 commits into from Jun 4, 2018

Conversation

emilbols
Copy link
Contributor

@emilbols emilbols commented Jun 4, 2018

This PR adds a new DeepFlavour training made on 10X MC, which outperforms the previous 94X training on MC.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 4, 2018

A new Pull Request was created by @emilbols for branch master.

@cmsbuild, @smuzaffar, @gudrutis, @mrodozov can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

external issue cms-sw/cmsdist#4084

@slava77
Copy link

slava77 commented Jun 4, 2018

From cms-sw/cmssw#23467

PR #23206 also introduced the 94X training which was made a while back. While that PR was ongoing we produced a 10X training, which performs better, so in this PR we also add a new DeepFlavour model trained on 10X MC samples. It is therefore required that the PR #14 is merged first.

Will the 94X training still be used?
If not, can we cleanup the repository?

@emilbols
Copy link
Contributor Author

emilbols commented Jun 4, 2018

@slava77 @mverzett @imarches It probably wont be used, so I have removed it. It has already been used in some of the 2018 commissioning plots, so I dont know if there is some people, who have a reason they want to keep it here. If there is any objections, I can add it again.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 4, 2018

Pull request #14 was updated.

external issue cms-sw/cmsdist#4084

@smuzaffar
Copy link
Contributor

cmsdist PR for 10.2.X is cms-sw/cmsdist#4086

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants