Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added model files for egamma PFid DNN #9

Merged
merged 1 commit into from Oct 14, 2021
Merged

Conversation

valsdav
Copy link
Contributor

@valsdav valsdav commented Oct 1, 2021

The new folder Photon_PFID_dnn contains both the tensorflow model files (.pb) and the configs files for the Egamma PFid DNN.
The .txt config files contain both the list of variables to be used for each model and their scaling configuration.

This is related to the PR cms-sw/cmssw#35403 for CMSSW_12_1_0.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 1, 2021

A new Pull Request was created by @valsdav (Davide Valsecchi) for branch master.

@smuzaffar, @mrodozov, @iarspider, @cmsbuild, @slava77, @jpata can you please review it and eventually sign? Thanks.
@Sam-Harper, @jainshilpi, @lgray, @sobhatta, @afiqaize, @wrtabb, @varuns23, @ram1123 this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.
cms-bot commands are listed here

@jpata
Copy link

jpata commented Oct 13, 2021

+reconstruction

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-dbe0fd/19588/summary.html
COMMIT: 8f302f7
CMSSW: CMSSW_12_1_X_2021-10-12-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-data/RecoEgamma-PhotonIdentification/9/19588/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 40
  • DQMHistoTests: Total histograms compared: 2798082
  • DQMHistoTests: Total failures: 5
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 2798054
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.004 KiB( 39 files compared)
  • DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
  • Checked 169 log files, 37 edm output root files, 40 DQM output files
  • TriggerResults: no differences found

@jpata
Copy link

jpata commented Oct 14, 2021

Just to make sure we do the steps of coupled PRs correctly, could this PR with just new files be merged?

@perrotta
Copy link

+1

  • Only new files are added, which will be needed by #35403

@perrotta
Copy link

@smuzaffar I can even merge this one myself (similar to cms-data/RecoEgamma-ElectronIdentification#23 but for photons rather than electron), but maybe you also want to have a look...

@smuzaffar
Copy link

+externals

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

@smuzaffar
Copy link

new files only, bot has opened cms-sw/cmsdist#7389 which can be merged before cms-sw/cmssw#35403

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants