Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates from Igrof master for Ubuntu which might help with EL8 #5

Merged
merged 15 commits into from Jan 31, 2023
Merged

Updates from Igrof master for Ubuntu which might help with EL8 #5

merged 15 commits into from Jan 31, 2023

Conversation

gartung
Copy link
Member

@gartung gartung commented Dec 5, 2022 •
edited

I want to test to see if this helps with memory undercounting on EL8.

gartung and others added 6 commits September 1, 2020 17:19
@gartung
Don't remove /1 unless it is at the end of the url. (igprof#84)
03d16c1
@ktf
Create README.md
7a3168c
@gartung
Handle ENDBR64 instruction (igprof#91)
e630848
@ktf
Correct 'abort' symbol signature
c0f7bde 
GCC 7 (r244326) complains about comparing two function pointers with
different singatures on src/profile.cc:580:24

    src/profile.cc: In function 'bool igprof_init(const char*, void (*)(), bool, double)':
    src/profile.cc:580:24: error: comparison between distinct pointer types 'void (*)() __attribute__((noreturn))' and 'void (*)() throw ()' lacks a cast [-fpermissive]
       if (igprof_abort != &abort)
                        ^~~~~

Signed-off-by: David Abdurachmanov <David.Abdurachmanov@cern.ch>
@ktf
Add __builtin_unreachable to IgProfBuffer::allocateRaw
98919f7 
GCC 7 (r244326) complains that we reach end of function with non-void
return. Add __builtin_unreachable right after abort function to tell
compiler that any code after abort is not possible.

Alternatively we could return 0x0/NULL after abort.

Signed-off-by: David Abdurachmanov <David.Abdurachmanov@cern.ch>
@ktf
Fix to work on Ubuntu 18.4 and subsequent ones
58942b6
@gartung
Copy link
Member Author

gartung commented Dec 5, 2022

enable profiling

@cmsbuild
Copy link

cmsbuild commented Dec 5, 2022

A new Pull Request was created by @gartung (Patrick Gartung) for branch cms/master/c6882f4.

@cmsbuild, @smuzaffar, @aandvalenzuela, @iarspider can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link

cmsbuild commented Dec 5, 2022

Pull request #5 was updated.

@gartung gartung changed the title Revert changes made to deal with TBB resumable tasks. Revert changes made to deal with TBB resumable tasks and updates from Igrof master for Ubuntu. Dec 5, 2022
@cmsbuild
Copy link

cmsbuild commented Dec 6, 2022

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-248d20/29469/summary.html
COMMIT: 679924e
CMSSW: CMSSW_13_0_X_2022-12-05-1100/el8_amd64_gcc11
Additional Tests: PROFILING
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-externals/igprof/5/29469/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3421337
  • DQMHistoTests: Total failures: 152
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3421163
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 206 log files, 158 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@cmsbuild
Copy link

cmsbuild commented Dec 6, 2022

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-248d20/29468/summary.html
COMMIT: 679924e
CMSSW: CMSSW_13_0_X_2022-12-05-1100/slc7_amd64_gcc11
Additional Tests: PROFILING
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-externals/igprof/5/29468/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 62347 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3421337
  • DQMHistoTests: Total failures: 121015
  • DQMHistoTests: Total nulls: 229
  • DQMHistoTests: Total successes: 3300071
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.10599999999999987 KiB( 47 files compared)
  • DQMHistoSizes: changed ( 10224.0 ): 0.469 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 11834.0 ): 1.482 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 250202.181 ): -0.053 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 25202.0 ): 0.488 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 7.3 ): -2.492 KiB SiStrip/MechanicalView
  • Checked 206 log files, 158 edm output root files, 48 DQM output files
  • TriggerResults: found differences in 17 / 46 workflows

@gartung
Copy link
Member Author

gartung commented Dec 6, 2022

The undercounting still exists for cpu performance.

@gartung gartung closed this Dec 6, 2022
@ktf
Handle sprintf depreation
4fb2ccf 
sprintf is marked as deprecated under XCode 13, resulting
in compiler errors due to the stricted options we use.

We move everything to use snprintf to silence the warning and
maybe avoid some buffer overrun.
@gartung gartung reopened this Dec 6, 2022
@gartung
Copy link
Member Author

gartung commented Jan 27, 2023

please test with cms-sw/cmsdist#8269

@gartung
Copy link
Member Author

gartung commented Jan 27, 2023

please test with cms-sw/cmsdist#8269 for slc7_amd64_gcc11

@cmsbuild
Copy link

Pull request #5 was updated.

@smuzaffar
Copy link

please test with cms-sw/cmsdist#8269

@smuzaffar
Copy link

please test with cms-sw/cmsdist#8269 for slc7_amd64_gcc11

@cmsbuild
Copy link

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-248d20/30214/summary.html
COMMIT: 66805e0
CMSSW: CMSSW_13_0_X_2023-01-27-1100/el8_amd64_gcc11
Additional Tests: PROFILING
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-externals/igprof/5/30214/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3555495
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3555467
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 211 log files, 162 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@cmsbuild
Copy link

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-248d20/30215/summary.html
COMMIT: 66805e0
CMSSW: CMSSW_13_0_X_2023-01-27-1100/slc7_amd64_gcc11
Additional Tests: PROFILING
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-externals/igprof/5/30215/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 65374 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3555495
  • DQMHistoTests: Total failures: 156946
  • DQMHistoTests: Total nulls: 272
  • DQMHistoTests: Total successes: 3398255
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -3.32 KiB( 48 files compared)
  • DQMHistoSizes: changed ( 10224.0 ): 0.469 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 11834.0 ): -1.732 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 250202.181 ): -0.053 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 25202.0 ): 0.488 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 7.3 ): -2.492 KiB SiStrip/MechanicalView
  • Checked 211 log files, 162 edm output root files, 49 DQM output files
  • TriggerResults: found differences in 18 / 47 workflows

@gartung gartung mentioned this pull request Jan 28, 2023
Merged
@gartung gartung closed this Jan 28, 2023
@gartung gartung reopened this Jan 28, 2023
@cmsbuild
Copy link

Pull request #5 was updated.

@gartung gartung merged commit a505ed3 into cms-externals:cms/master/c6882f4 Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
externals-pending orp-pending pending-signatures tests-pending
Projects
None yet
Milestone
No milestone
4 participants
@gartung @cmsbuild @smuzaffar @ktf