Fat event filter fix #437
Closed
Fat event filter fix #437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
fwyzard
reviewed
Nov 25, 2016
| if (useTCDS_ && period_!=0) { | ||
| evf::evtn::TCDSRecord record((unsigned char *)data.data()); | ||
| accept = ( (record.getHeader().getData().header.triggerCount % period_) == 0 ); | ||
| } |
There was a problem hiding this comment.
hi Jim, could you move around the code to be something like
if (period_!=0) {
if (useTCDS_) {
evf::evtn::TCDSRecord record((unsigned char *) data.data());
accept = ( (record.getHeader().getData().header.triggerCount % period_) == 0 );
} else {
accept = ( ( (header.lvl1ID())%period_ ) == 0 );
}
}
?
There was a problem hiding this comment.
Actually, one could move the if (period_!=0) even before the access to the event, though it is quite unlikely for this filter to be used that way.
There was a problem hiding this comment.
It may be cleaner to get a counter from either TCDS or the lvl1ID, depending on the configuration, and then write the (counter % period_) == 0 logic only once.
|
Further developed versions of this PR are merged in 90x (cms-sw#17082) and back-ported to 80x (cms-sw#16806). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for fat event filters (L1T and HLT) to keep l1t-integration in sync with CMSSW PRs cms-sw#16765 and cms-sw#16766.