fixed segmentation violation that occurred in subjet analyses in case…

[ktht]

… a pat::Jet had daughters of type pat::Jet

(previous code only handled the case that daughters of pat::Jet were of type reco::PFJet)

[arizzi]

can we send this directly to cmssw? master & 94X branches

[veelken]

I confirm that the fix can go into cmssw (master & 94X branches)

[arizzi]

can you guys open the relevant PR in master and 94X branches?

[ktht]

Which one(s) from the 94X branches exactly? CMSSW_9_4_X? Anything else?

[arizzi]

I think this can go into main CMSSW_9_4_X and will be auto fwd ported to MAOD branch

[gpetruc]

I think we can merge it also in here (it's the same commit as cms-sw#22294 ) if it doesn't trigger a too lengthy recompilation - testing that now using the bot

[gpetruc-bot]

Automatic test started, see https://gitlab.cern.ch/cms-nanoAOD/nanoAOD-integration/pipelines/312110/builds

[veelken]

The corresponding PR for the CMSSW 9_4_x branch is here: cms-sw/cmssw@CMSSW_9_4_X...HEP-KBFI:fixSIGSEGV

[gpetruc-bot]

Automatic test report for 312110

• gitlab pipeline at https://gitlab.cern.ch/cms-nanoAOD/nanoAOD-integration/pipelines/312110/builds
• outputs at https://test-cms-nanoaod-integration.web.cern.ch/integration/test_pr_111/

Code integration

Code checks passed for this PR

Tests

• Long test data80X (10000 events): passed, no significant changes; dqm plots: all, diff
• Long test data80Xhip (3000 events): passed, no significant changes; dqm plots: all, diff
• Long test data94X (10000 events): passed, no significant changes; dqm plots: all, diff
• Long test mc80X (10000 events): passed, no significant changes; dqm plots: all, diff
• Long test mc94X (10000 events): passed, no significant changes; dqm plots: all, diff
• Test mc_94X: passed
• Test mc_80X: passed
• Test mc_92X: passed
• Test data_92X: passed
• Test data_80X: passed

Disk size report

Sample	kb/event	ref kb/event	diff
TTbar MC 94X	1.509	1.509	0.000 ( +0.0% )
TTbar MC 80X	1.557	1.557	-0.000 ( -0.0% )
Data 94X	0.611	0.610	0.000 ( +0.0% )
Data 80X	0.577	0.577	-0.000 ( -0.0% )
Data 80X, Mu Run2016E	0.508	0.507	0.000 ( +0.1% )

[ktht]

PR merged in master: cms-sw#22298; 94X still open, though.

[veelken]

Hi,

would be great if this PR can be merged soon.

Cheers,

Christian

[arizzi]

@gpetruc given that there isn't yet a full 94X release with the dependency PR included, how do we want to proceed?

• wait for 9_4_5
• merge the needed commit here too? (but then it conflicts on 10XY?)
• move our ref to an IB

[gpetruc]

I think we can merge the 94X commit here, if it's from the same branch that went in the CMSSW 94X PR. In the 10_X we can merge the master PR one

…

On Wed, Mar 14, 2018 at 9:15 AM, arizzi ***@***.***> wrote: @gpetruc <https://github.com/gpetruc> given that there isn't yet a full 94X release with the dependency PR included, how do we want to proceed? - wait for 9_4_5 - merge the needed commit here too? (but then it conflicts on 10XY?) - move our ref to an IB — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#111 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AEbbRyKoVVf2-PI1OoJ8Bu3Z_nhrjRMAks5teNGagaJpZM4SAGCb> .

[arizzi]

but then the fwd port of our features to our 10XY master is less trivial (we have to remember the commit to remove) ...