Betastar application #358
Closed
Betastar application #358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manage PluginFactory plugin with unique_ptr in DTLocalTriggerSynchTask
…tions No more possibility to ignore exceptions in TagAndProbe
The function takes a short, not a double. This fixes a clang warning.
…ime/FTLRecProducers This works for PluginFactory returning either raw pointer or unique_ptr.
…HGCal This works for PluginFactory returning either raw pointer or unique_ptr.
…mLowPtEleTracks_V1 Conversions from low pt ele tracks released in PR 25455
Some modernization for SiPixelClusterProducer
…ckedIntoRAW_10_4_0_v1 Pixel simulated bad channel info packed into FED raw data
Phase2-sim26 Add one simproducer class which can save hits of calorimeters
alca - removing '//' from header include.
simulation - removing '//' from header include.
Pass intergral value to SetLineWidth in CondCore/EcalPlugins
…mDataFormats Modernize dictionary generation in FastSimDataFormats
DD4Hep: DT Geometry Builder
…hase1 to use a Deep Neural Network implemented in the LWTNN package instead of Boosted Decision Trees
With the cost of a mutable member
…classifies to the general collection
…o when the trackingPhase1 uses DNN
…AClassifierBase instead of being hard coded.
…mva loop to use reference instead of copy
…PixelTripletNoTipGenerator Avoid a possible memory leak in PixelTripletNoTipGenerator.cc
Geometry/GEMGeometryBuilder/src/GEMGeometryBuilderFromDDD.cc const-cast fix
Utilities and fixes for HipPy alignment
…l_from-CMSSW_10_5_0_pre1 Add label for pixel digitizer in SiPixelQualityESProducer
Add missing overide in HTXSRivetProducer
Fix clang warnings in LzmaFile
Fix clang warning in AMPTHadronizer
Modernized MCPdgIndexFilter
…GammaGamma Use auto for iterator declaration in PythiaHepMCFilterGammaGamma
…ClusterProducer Clean-up RecoParticleFlow/PFClusterProducer
…_SCbugfix Low pT electrons: bug fix for SuperCluster class
Add support for EDAlias as a case in SwitchProducer
[105X] removing three fragments from override (backport of cms-sw#25955)
…oCond GT instead of hardcoded prompt GT for heavy Ion data relval
This reverts commit f689a30.
Backport : Update GT for ultra legacy - MC ECAL, GEM eMap
…D production chain.
|
There is clearly something wrong here, please either open a PR to master-102X for 10_2_X or to master-cmsswmaster for 10_6_X. |
|
I close this for the moment, as it would in any case need the implementation of new features in CMSSW (at this point, in master + 10_6_X + 10_2_X). Please reopen when ready. |
|
Ok, this seems sensible. I will create a new pull request for these changes (in another CMSSW version) when the changes in PR [1] are accepted. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description:
This PR pairs up with the PR [1], which updated some of the structures that were added originally to cmssw in [2]. The reasons for those changes are motivated in [1], and are not to be duplicated here. Only the file jets_cff.py is edited here, as the only target of this PR is to add the given variables to the NANOAOD workflow.
The target of this PR is to partially substitute for the changes that are introduced in the still ongoing PR [3]. If the new PR [1] is accepted, the changes presented here should be considered, instead of those given in [3].
The code has been edited in CMSSW version 10_5_0, for which somehow an automatic merge was not available here.
[1] cms-sw#26767
[2] cms-sw#25223
[3] #246