Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updates in reco Comparisons: monitor PUPPI jets #1280

Merged
merged 2 commits into from Mar 26, 2020

Conversation

slava77
Copy link
Contributor

@slava77 slava77 commented Mar 26, 2020

  • prod-like datasets for phase-1/2 workflows (used for private tests so far)
  • monitor puppi jets in RECO to support changes added in PUPPI jets in RECO cmssw#28936
  • add a set of jet tag plots for AK8 with pt > 200 GeV, which roughly corresponds to the range where these are used for physics (while many jets are left untagged for lower momentum range)

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @slava77 (Slava Krutelyov) for branch master.

@cmsbuild, @smuzaffar, @mrodozov, @tulamor can you please review it and eventually sign? Thanks.
cms-bot commands are listed here

@slava77
Copy link
Contributor Author

slava77 commented Mar 26, 2020

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 26, 2020

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/5401/console Started: 2020/03/26 15:36

@cmsbuild
Copy link
Contributor

+1
Tested at: e769a82
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-106549/5401/summary.html
CMSSW: CMSSW_11_1_X_2020-03-26-1100
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-106549/5401/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2692110
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2691789
  • DQMHistoTests: Total skipped: 319
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 147 log files, 16 edm output root files, 34 DQM output files

@slava77
Copy link
Contributor Author

slava77 commented Mar 26, 2020

It looks like the reco comparisons finished OK; this validates the update in validate.C

@smuzaffar
Copy link
Contributor

+externals

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @silviodonato, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants