Move WEB to DEPS before deletion and rename packages to package.json #1423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A new Pull Request was created by @mrodozov (Mircho Rodozov) for branch master. @cmsbuild, @smuzaffar, @mrodozov can you please review it and eventually sign? Thanks. |
smuzaffar
reviewed
Nov 20, 2020
build-cmssw-ib-with-patch
Outdated
| @@ -173,7 +173,8 @@ pushd CMSDIST | |||
| popd | |||
|
|
|||
| PYTHONPATH= $CMSBUILD_CMD ${EX_OPTS} --specs-only build $PACKAGE_NAME | |||
| rm -rf ${WRKDIR}/WEB | |||
| mv ${WRKDIR}/WEB ${WRKDIR}/DEPS | |||
| for i in `ls ${WRKDIR}/DEPS/${ARCHITECTURE}`; do mv ${WRKDIR}/DEPS/${ARCHITECTURE}/$i ${WRKDIR}/DEPS/${ARCHITECTURE}/$(echo $i | tr "+" " " | awk '{print $2}').json; done | |||
There was a problem hiding this comment.
remove this change. json created here should not be uploaded.
smuzaffar
reviewed
Nov 20, 2020
| @@ -194,7 +195,8 @@ if [ "${DRY_RUN}" = "" ] ; then | |||
| echo DATE=`date` | |||
| rm -rf ${WRKDIR}/tmp | |||
| PYTHONPATH= $CMSBUILD_CMD ${EX_OPTS} deprecate-local $TOOL_CONF_PACKAGES | |||
| rm -rf ${WRKDIR}/WEB | |||
| mv ${WRKDIR}/WEB ${WRKDIR}/DEPS | |||
| for i in `ls ${WRKDIR}/DEPS/${ARCHITECTURE}`; do mv ${WRKDIR}/DEPS/${ARCHITECTURE}/$i ${WRKDIR}/DEPS/${ARCHITECTURE}/$(echo $i | tr "+" " " | awk '{print $2}').json; done | |||
There was a problem hiding this comment.
this is correct change. Please cleanup the one at line number 176, 177
mrodozov
force-pushed
the
rename-web-to-deps-and-use-only-package-names
branch
from
40909b5
to
064d9d5
Compare
|
Pull request #1423 was updated. |
mrodozov
force-pushed
the
rename-web-to-deps-and-use-only-package-names
branch
from
064d9d5
to
26be875
Compare
|
Pull request #1423 was updated. |
mrodozov
force-pushed
the
rename-web-to-deps-and-use-only-package-names
branch
from
26be875
to
018cb93
Compare
|
Pull request #1423 was updated. |
mrodozov
force-pushed
the
rename-web-to-deps-and-use-only-package-names
branch
from
018cb93
to
2d9f1b9
Compare
|
Pull request #1423 was updated. |
|
The tests are being triggered in jenkins.
|
|
-1 Tested at: 2d9f1b9 CMSSW: CMSSW_11_2_ROOT622_X_2020-11-19-2300 I found follow errors while testing this PR Failed tests: Build
I found compilation error when building: >> Compiling /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_ROOT622_X_2020-11-19-2300/src/PhysicsTools/TensorFlow/src/TensorFlow.cc
In file included from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_ROOT622_X_2020-11-19-2300/src/PhysicsTools/TensorFlow/interface/TensorFlow.h:12,
from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_ROOT622_X_2020-11-19-2300/src/PhysicsTools/TensorFlow/src/TensorFlow.cc:9:
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/slc7_amd64_gcc820/external/tensorflow/2.3.1-49496958be0296e3b366e33aa8ec3622/include/tensorflow/core/framework/tensor.h: In instantiation of 'typename tensorflow::TTypes::Scalar tensorflow::Tensor::scalar() [with T = std::__cxx11::basic_string; typename tensorflow::TTypes::Scalar = Eigen::TensorMap, Eigen::Sizes<>, 1, long int>, 16, Eigen::MakePointer>]':
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_ROOT622_X_2020-11-19-2300/src/PhysicsTools/TensorFlow/src/TensorFlow.cc:143:39: required from here
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/slc7_amd64_gcc820/external/tensorflow/2.3.1-49496958be0296e3b366e33aa8ec3622/include/tensorflow/core/framework/tensor.h:879:7: error: static assertion failed: std::string is no longer a scalar type, use tensorflow::tstring
!std::is_same::value,
^~~~
gmake: *** [tmp/slc7_amd64_gcc820/src/PhysicsTools/TensorFlow/src/PhysicsToolsTensorFlow/TensorFlow.cc.o] Error 1
>> Building shared library tmp/slc7_amd64_gcc820/src/PhysicsTools/TensorFlow/src/PhysicsToolsTensorFlow/libPhysicsToolsTensorFlow.so
c++: error: tmp/slc7_amd64_gcc820/src/PhysicsTools/TensorFlow/src/PhysicsToolsTensorFlow/TensorFlow.cc.o: No such file or directory
|
|
Comparison not run due to Build errors (RelVals and Igprof tests were also skipped) |
cmsbuild
added
comparison-notrun
tests-rejected
and removed
comparison-pending
tests-started
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lets test it with a PR