Another fix for static analyzer script.

[gartung]

No description provided.

[cmsbuild]

A new Pull Request was created by @gartung (Patrick Gartung) for branch master.

@cmsbuild, @smuzaffar, @mrodozov, @iarspider can you please review it and eventually sign? Thanks.
cms-bot commands are listed here

[gartung]

@mrodozov @smuzaffar

[gartung]

please test with cms-sw/cmssw#33870

[cmsbuild]

-1

Failed Tests: Build ClangBuild
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2e6765/15368/summary.html
COMMIT: e45a904
CMSSW: CMSSW_12_0_X_2021-05-27-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cms-bot/1558/15368/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• Rename pixelVertexCUDA|SoA to pixelVerticesCUDA|SoA cmssw#33844 @fwyzard: Rename pixelVertexCUDA|SoA to pixelVerticesCUDA|SoA
• MTD geometry: Specify explicitly the geometry era in standalone MTD tests cmssw#33842 @fabiocos: MTD geometry: Specify explicitly the geometry era in standalone MTD tests
• Migrate part of PPS modules to use esConsumes cmssw#33848 @fabferro: Migrate part of PPS modules to use esConsumes
• [Tracker Alignment] Introduce ALCARECOTkAlDiMuonAndVertex cmssw#33770 @mmusich: [Tracker Alignment] Introduce ALCARECOTkAlDiMuonAndVertex
• HcalDQM - Correct LED Calibration Channels List cmssw#33827 @lwang046: HcalDQM - Correct LED Calibration Channels List
• [HGCAL] Pattern Recognition as Plugins, with CLUE3D addition. cmssw#33645 @rovere: [HGCAL] Pattern Recognition as Plugins, with CLUE3D addition.
• Run3-alca184 Add a new analyzer for studies of HCAL using isotrack and muons cmssw#33810 @bsunanda: Run3-alca184 Add a new analyzer for studies of HCAL using isotrack and muons
• L1 phase 2: produce CaloJet/Tau (corrected version) cmssw#33750 @cecilecaillol: L1 phase 2: produce CaloJet/Tau (corrected version)

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2e6765/15368/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2e6765/15368/git-merge-result

Build

I found compilation error when building:

>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_0_X_2021-05-27-1100/src/Calibration/HcalCalibAlgos/test/HcalHBHEMuonSimAnalyzer.cc
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_0_X_2021-05-27-1100/src/Calibration/HcalCalibAlgos/test/HcalIsoTrackAnalysis.cc
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_0_X_2021-05-27-1100/src/Calibration/HcalCalibAlgos/test/HcalIsoTrackStudy.cc
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_0_X_2021-05-27-1100/src/Calibration/HcalCalibAlgos/test/HcalLaserTest.cc
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_0_X_2021-05-27-1100/src/Calibration/HcalCalibAlgos/test/ValidationHcalIsoTrackAlCaReco.cc
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_0_X_2021-05-27-1100/src/Calibration/HcalCalibAlgos/test/HcalHBHEMuonSimAnalyzer.cc:33:10: fatal error: Geometry/CaloEventSetup/interface/CaloTopologyRecord.h: No such file or directory
   33 | #include "Geometry/CaloEventSetup/interface/CaloTopologyRecord.h"
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_0_X_2021-05-27-1100/src/Calibration/HcalCalibAlgos/test/HcalHBHEMuonSimAnalyzer.cc:33:10: fatal error: Geometry/CaloEventSetup/interface/CaloTopologyRecord.h: No such file or directory
   33 | #include "Geometry/CaloEventSetup/interface/CaloTopologyRecord.h"


Clang Build

I found compilation error while trying to compile with clang. Command used:

USER_CUDA_FLAGS='--expt-relaxed-constexpr' USER_CXXFLAGS='-Wno-register -fsyntax-only' scram build -k -j 32 COMPILER='llvm compile'

>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_0_X_2021-05-27-1100/src/Calibration/HcalCalibAlgos/test/HcalHBHEMuonSimAnalyzer.cc
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_0_X_2021-05-27-1100/src/Calibration/HcalCalibAlgos/test/HcalIsoTrackAnalysis.cc
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_0_X_2021-05-27-1100/src/Calibration/HcalCalibAlgos/test/HcalIsoTrackStudy.cc
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_0_X_2021-05-27-1100/src/Calibration/HcalCalibAlgos/test/HcalLaserTest.cc
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_0_X_2021-05-27-1100/src/Calibration/HcalCalibAlgos/test/ValidationHcalIsoTrackAlCaReco.cc
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_0_X_2021-05-27-1100/src/Calibration/HcalCalibAlgos/test/HcalHBHEMuonSimAnalyzer.cc:33:10: fatal error: 'Geometry/CaloEventSetup/interface/CaloTopologyRecord.h' file not found
#include "Geometry/CaloEventSetup/interface/CaloTopologyRecord.h"
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_0_X_2021-05-27-1100/src/Calibration/HcalCalibAlgos/test/HcalHBHEMuonSimAnalyzer.cc:33:10: fatal error: 'Geometry/CaloEventSetup/interface/CaloTopologyRecord.h' file not found
#include "Geometry/CaloEventSetup/interface/CaloTopologyRecord.h"


[mrodozov]

please test with cms-sw/cmssw#33870, cms-sw/cmssw#33875

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2e6765/15377/summary.html
COMMIT: e45a904
CMSSW: CMSSW_12_0_X_2021-05-27-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cms-bot/1558/15377/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 37
• DQMHistoTests: Total histograms compared: 2650486
• DQMHistoTests: Total failures: 7
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2650457
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
• Checked 155 log files, 37 edm output root files, 37 DQM output files
• TriggerResults: no differences found

[mrodozov]

+externals
we need at least 33870

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1