add labeling for tracking

[slava77]

add packages and subsystems to be labeled for tracking

• "CUDADataFormats/Track",
• "DataFormats/Track",
• "RecoPixelVertexing",
• "RecoTracker",
• "RecoVertex",
• "TrackPropagation",
  • will also match to TrackPropagation/SteppingHelixPropagator, which is mostly muon reco, but it's probably still OK for tracking
• "TrackingTools"
  • will also match TrackingTools/TrackAssociator, which is not tracking, but the alternative is to write a much longer list. So, we could probably unassign

@mmusich
do you have any comments?

[cmsbuild]

A new Pull Request was created by @slava77 (Slava Krutelyov) for branch master.

@cmsbuild, @smuzaffar, @aandvalenzuela, @iarspider can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.
cms-bot commands are listed here

[cmsbuild]

Pull request #1916 was updated.

[mmusich]

does it mean they will get labelled automatically?

[mmusich]

Not sure if we need also RecoPixelVZero and RecoVZero (do not exist anymore since a long time).
Do we need to flag also non reconstruction packages?

[slava77]

Do we need to flag also non reconstruction packages?

good point, here is more that matches

• CUDADataFormats/Vertex
• DataFormats/VertexReco
• DQM/Tracking
• Validation/RecoPixelVertexing
• Validation/RecoTrack
• Validation/RecoVertex
• Validation/Tracking
• FastSimulation/Tracking
• Geometry/GlobalTracking

what else?

[slava77]

Not sure if we need also RecoPixelVZero and RecoVZero (do not exist anymore since a long time).

these were apparently removed in 9_2_X ( cms-sw/cmssw#18623) 10_0_X (cms-sw/cmssw#21456), respectively
But I guess I can add these as well

[mmusich]

I would add:

• CondFormats/BeamSpotObjects
• AnalysisDataFormats/TrackInfo
• CondCore/BeamSpotPlugins
• CondFormats/BeamSpotObjects
• CondTools/BeamSpot
• DQM/BeamMonitor
• Validation/TrackingMCTruth (already covered above)

[slava77]

I would add:

now in f2c36cc

[slava77]

actually in 9d8c766

[cmsbuild]

Pull request #1916 was updated.

[slava77]

does it mean they will get labelled automatically?

yes

[cmsbuild]

Pull request #1916 was updated.

[mmusich]

looks good to me!

[mmusich]

there is tracking related code in CommonTools/RecoAlgos and possibly also scattered in other packages. I guess we can still flag by hand when needed.

[slava77]

there is tracking related code in CommonTools/RecoAlgos and possibly also scattered in other packages. I guess we can still flag by hand when needed.

right, I don't think there is a way to tag by individual files.

[smuzaffar]

files information is available and we can use that for these labels.

[mmusich]

files information is available and we can use that for these labels.

doing a survey down to the file level now would be extremely tedious. I would suggest to continue incorporating files in the list once concrete requests materialize. What do you think?

[slava77]

files information is available and we can use that for these labels.

would this work already, or does it need some updates in the bot?

[smuzaffar]

files information is available and we can use that for these labels.

would this work already, or does it need some updates in the bot?

No, it needs changes in bot code.

[smuzaffar]

@slava77 , should I update bot to do the matching against the changed file ?

[slava77]

@slava77 , should I update bot to do the matching against the changed file ?

I think that we can merge this PR first and then benefit from the file-level selection when it is available.

[smuzaffar]

this has been merged and bot properly added the label for cms-sw/cmssw#30373