Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

propagate documentation updates #95

Merged
merged 5 commits into from Mar 10, 2018
Merged

Conversation

kpedro88
Copy link
Contributor

@kpedro88 kpedro88 commented Mar 9, 2018

I finally figured out the right way to propagate man page updates here:

  • edit the files in doc/man
  • run make -> updates the files in doc/man/man1

I touched all the files (to pull in earlier updates that hadn't been propagated with make) and made a few more fixes.

@cmsbuild
Copy link

cmsbuild commented Mar 9, 2018

A new Pull Request was created by @kpedro88 (Kevin Pedro) for branch master.

@cmsbuild, @smuzaffar, @gudrutis, @mrodozov can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

external issue cms-sw/cmsdist#3826

@smuzaffar
Copy link
Contributor

@kpedro88 , I do not remember why this was not done with in spec file. I would suggest to drop all the generated files and we run make during build.

@cmsbuild
Copy link

Pull request #95 was updated.

external issue cms-sw/cmsdist#3826

@kpedro88
Copy link
Contributor Author

@smuzaffar yes, that would make more sense. I updated this PR to remove the generated files, and updated the makefile to create the output dir before trying to fill it (while ignoring it in .gitignore).

@cmsbuild
Copy link

Pull request #95 was updated.

external issue cms-sw/cmsdist#3826

@kpedro88
Copy link
Contributor Author

can you update the spec file?

@smuzaffar
Copy link
Contributor

spec is updated : cms-sw/cmsdist#3837

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants