Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Use a private pythia8 200pre1 tarball in cmsdist 73x with some o... #1046

Merged
1 commit merged into from Sep 22, 2014

Conversation

ghost
Copy link

@ghost ghost commented Sep 22, 2014

Reverts #1028

I missed it the first time but this PR actually breaks evtgen which requires to update its use of pythia API.
Example error:

EvtGenExternal/EvtPythiaEngine.cpp:240:40: error: 'class Pythia8::Event' has no member named 'daughterList'
std::vector<int> daugList = theEvent.daughterList(startInt);

ghost pushed a commit that referenced this pull request Sep 22, 2014
Revert "Use a private pythia8 200pre1 tarball in cmsdist 73x with some o...
@ghost ghost merged commit 086db1c into IB/CMSSW_7_3_X/stable Sep 22, 2014
@ghost ghost deleted the revert-1028-topythia8200pre1 branch September 22, 2014 14:29
@bendavid
Copy link
Contributor

@Degano, is this problem in the CMSSW interface or in evtgen itself?

@ghost
Copy link
Author

ghost commented Sep 22, 2014

@bendavid with evtgen itself I would say as it appear when compiling it as external.

@bendavid
Copy link
Contributor

There are multiple evtgen specs in cmsdist, is it the one associated with
https://github.com/cms-sw/cmsdist/blob/IB/CMSSW_7_3_X/stable/evtgen.spec
?

@ghost
Copy link
Author

ghost commented Sep 22, 2014

Yes, the issue appear when explicitly building that one.

@bendavid
Copy link
Contributor

Ok thanks, can you confirm whether there is any issue with tauolapp, which also declares pythia8 as a dependency?

@ghost
Copy link
Author

ghost commented Sep 22, 2014

tauolapp looks fine.

@bendavid
Copy link
Contributor

Thanks,
This should be straightforward to solves on the pythia side. Will try to get it taken care of together with the other needed header changes. (ie 8.200pre2 coming soon with this addressed)

bendavid added a commit to bendavid/cmsdist that referenced this pull request Sep 24, 2014
…ia8200pre1"

This is the revert of the revert of the pythia8 changes.

This reverts commit 086db1c, reversing
changes made to d04e9c8.
bendavid added a commit to bendavid/cmsdist that referenced this pull request Sep 28, 2014
…ia8200pre1"

This is the revert of the revert of the pythia8 changes.

This reverts commit 086db1c, reversing
changes made to d04e9c8.
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants