Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ipython to 3.1.0. #1543

Merged
1 commit merged into from May 17, 2015
Merged

Update ipython to 3.1.0. #1543

1 commit merged into from May 17, 2015

Conversation

ghost
Copy link

@ghost ghost commented May 12, 2015

Requested in: #1540

@ghost
Copy link
Author

ghost commented May 12, 2015

-1
Compilation is fine.
However cmssw package PhysicsTools/HeppyCore needs to be update accordingly.

@ghost ghost mentioned this pull request May 12, 2015
@ghost
Copy link
Author

ghost commented May 12, 2015

@davidlange6 @ktf As requested by @cbernet this is the update to ipython. However heppy in PhysicsTools/HeppyCore will break following this update.
Also, @cbernet asked this update for 74X particularly, I think however that we should first include it in 75X, fix the cmssw package and then backport everything to 74X. Do you agree?

@cbernet
Copy link

cbernet commented May 12, 2015

Hi Alessandro,

Could you please give me more details about why PhysicsTools/HeppyCore will break?
How can I test that?

Thanks,

Colin

Le 12 mai 2015 à 10:47, Alessandro Degano notifications@github.com a écrit :

@davidlange6 @ktf As requested by @cbernet this is the update to ipython. However heppy in PhysicsTools/HeppyCore will break following this update.
Also, @cbernet asked this update for 74X particularly, I think however that we should first include it in 75X, fix the cmssw package and then backport everything to 74X. Do you agree?


Reply to this email directly or view it on GitHub.

@ktf
Copy link
Contributor

ktf commented May 12, 2015

@Degano, maybe you can install ipython-toolfile by hand in AFS so that @cbernet can try it out.

@cmsbuild cmsbuild added this to the Next CMSSW_7_5_X milestone May 12, 2015
@ghost
Copy link
Author

ghost commented May 12, 2015

@ktf @cbernet Done installing on afs week0 volume.
@cbernet you can now setup ipython 3.1.0 in a 7_5_X release by doing:

scram setup /afs/cern.ch/cms/sw/ReleaseCandidates/vol0/slc6_amd64_gcc491/external/py2-ipython-toolfile/1.0-cms2/etc/scram.d/py2-ipython.xml
cmsenv

NOTE: Because of the usual IB volumes rotation this package will be available until Sunday 24th of May.

@cbernet
Copy link

cbernet commented May 12, 2015

@Degano: thank you very much.

Could you please tell me more about the problem you observed?

I did some testing, and I can see that I have to remove the -noconfirm_exit option from this script:

[test]$ cat PhysicsTools/HeppyCore/scripts/heppy
#!/usr/bin/env bash
ipython --pdb -noconfirm_exit -- $CMSSW_BASE/src/PhysicsTools/HeppyCore/python/framework/heppy.py "$@"

When I do that, it seems to work.
But:

  • I would like to be sure I have fixed the problem you are referring to, and not another one.
  • I’d like to know how you managed to catch that because I’m kind of impressed :-)

Le 12 mai 2015 à 14:51, Alessandro Degano notifications@github.com a écrit :

@ktf @cbernet Done installing on afs week0 volume.
@cbernet you can now setup ipython 3.1.0 in a 7_5_X release by doing:

scram setup /afs/cern.ch/cms/sw/ReleaseCandidates/vol0/slc6_amd64_gcc491/external/py2-ipython-toolfile/1.0-cms2/etc/scram.d/py2-ipython.xml
cmsenv
NOTE: Because of the usual IB volumes rotation this package will be available until Sunday 24th of May.


Reply to this email directly or view it on GitHub.

@ghost
Copy link
Author

ghost commented May 12, 2015

@cbernet That was the only issue I observed and frankly I don't know if there are more. As for how I caught it I just searched for ipython in cmssw repository ;)

@cbernet
Copy link

cbernet commented May 12, 2015

Nice catch anyway ;-)
As you have seen, I did a pull request with a fix. Please let me know if you need anything else.
Colin

@ktf
Copy link
Contributor

ktf commented May 12, 2015 via email

@ghost
Copy link
Author

ghost commented May 17, 2015

+1
cms-sw/cmssw#9054 have fixed the issue observed.
Merging now.

ghost pushed a commit that referenced this pull request May 17, 2015
@ghost ghost merged commit 8c9d9a5 into cms-sw:IB/CMSSW_7_5_X/stable May 17, 2015
@ghost ghost deleted the ipython_75X branch May 17, 2015 08:14
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants