Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade to evtgen 1.4.0p1 #1771

Merged
1 commit merged into from Aug 26, 2015
Merged

Conversation

mkirsano
Copy link
Contributor

No description provided.

@covarell
Copy link

+1

1 similar comment
@ghost
Copy link

ghost commented Aug 26, 2015

+1

ghost pushed a commit that referenced this pull request Aug 26, 2015
@ghost ghost merged commit 741fe58 into cms-sw:IB/CMSSW_7_6_X/stable Aug 26, 2015
@davidlt
Copy link
Contributor

davidlt commented Aug 27, 2015

This was not tested with CMSSW and IBs are broken (not compiling).

CMSSW_7_6_X_2015-08-26-2300/src/GeneratorInterface/EvtGenInterface/plugins/EvtGenUserModels/EvtLb2plnuLCSRFF.cpp:87:10: error: 'ERROR' was not declared in this scope
    report(ERROR,"EvtGen") << "Only Lb -> p transitions allowed in EvtLb2plnuLCSRFF.\n";  

@davidlange6 @smuzaffar

@ghost ghost mentioned this pull request Aug 27, 2015
@ghost
Copy link

ghost commented Aug 27, 2015

@davidlt Okay, for the time being I reverted it here: #1776

@smuzaffar
Copy link
Contributor

@mkirsano , looks like you need to use EvtGenReport(EVTGEN_ERROR,"EvtGen") instead of report(ERROR,"EvtGen")

Can you please provide a fix as soon as possible.

For now I have marked CMSSW_7_6_X_2015-08-26-2300 IB as bad one so ib-integration tests should not use it

@ghost
Copy link

ghost commented Aug 27, 2015

@smuzaffar I'm working on the fix myself, should be ready soon.

On Thu, Aug 27, 2015 at 9:51 AM, Malik Shahzad Muzaffar <
notifications@github.com> wrote:

@mkirsano https://github.com/mkirsano , looks like you need to use
EvtGenReport(EVTGEN_ERROR,"EvtGen") instead of report(ERROR,"EvtGen")

Can you please provide a fix as soon as possible.

For now I have marked CMSSW_7_6_X_2015-08-26-2300 IB as bad one so
ib-integration tests should not use it


Reply to this email directly or view it on GitHub
#1771 (comment).

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants