Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Advance data for RecoJets/JetProducers. #2166

Merged
1 commit merged into from Feb 26, 2016
Merged

Advance data for RecoJets/JetProducers. #2166

1 commit merged into from Feb 26, 2016

Conversation

ghost
Copy link

@ghost ghost commented Feb 25, 2016

@ghost
Copy link
Author

ghost commented Feb 25, 2016

@cmsbuild please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Degano (Alessandro Degano) for branch IB/CMSSW_8_1_X/stable.

@cmsbuild, @smuzaffar, @Degano, @iahmad-khan, @davidlange6 can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@slava77
Copy link
Contributor

slava77 commented Feb 25, 2016

@davidlange6
shouldn't we have equivalent CMSSW categories for externals?

In this particular case just new files are added, and cmssw code change is required to enable the feature.
However, sometimes file names stay but contents change and this case should be checked.

@slava77
Copy link
Contributor

slava77 commented Feb 25, 2016

Just making a note about cms-sw/cmssw#13472 so that the merge status of this PR is visible there.

For new files added in this package (no indiscriminate includes are present in the code runtime) we can get the update of the external in IBs and then proceed on cmssw side.

@davidlange6
Copy link
Contributor

is why we nominally want these requests raised at the ORP. But there are several ways to do it.

On Feb 25, 2016, at 1:52 PM, Slava Krutelyov notifications@github.com wrote:

@davidlange6
shouldn't we have equivalent CMSSW categories for externals?

In this particular case just new files are added, and cmssw code change is required to enable the feature.
However, sometimes file names stay but contents change and this case should be checked.


Reply to this email directly or view it on GitHub.

@slava77
Copy link
Contributor

slava77 commented Feb 26, 2016

@Degano
ping
This just adds new files.
Nothing will change or be noticed in the tests.

ghost pushed a commit that referenced this pull request Feb 26, 2016
Advance data for RecoJets/JetProducers.
@ghost ghost merged commit bb19935 into cms-sw:IB/CMSSW_8_1_X/stable Feb 26, 2016
@ghost ghost deleted the data_recojets_81X branch February 26, 2016 14:41
@slava77
Copy link
Contributor

slava77 commented Mar 2, 2016

We need 80X and 76X versions of this.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants