Resolve issue with PycURL not matching SSL backend #2220
Conversation
Signed-off-by: David Abdurachmanov <David.Abdurachmanov@cern.ch> (cherry picked from commit 79fdda9)
- Unset MAGIC because configure is using /bin/file instead finding file from the PATH. We cannot use magic file with a different version of file executable. - We want to see compilation lines, thus disable silent rules. Signed-off-by: David Abdurachmanov <David.Abdurachmanov@cern.ch> (cherry picked from commit 9cead63)
Bump version to 7.43.0.
Add missing dependency on OpenSSL (pycurl includes headers if OpenSSL is
selected as backend).
We have noticed the following issue in GCC 5.3.0 branch:
import pycurl
ImportError: pycurl: libcurl link-time ssl backend (openssl) is
different from compile-time ssl backend (none/other)
At compile time pycurl hardcoded the backend it's using:
src/pycurl.h:# define COMPILE_SSL_LIB "openssl"
src/pycurl.h:# define COMPILE_SSL_LIB "gnutls"
src/pycurl.h:# define COMPILE_SSL_LIB "nss"
src/pycurl.h:# define COMPILE_SSL_LIB "none/other"
src/pycurl.h:# define COMPILE_SSL_LIB "none/other"
Then at run-time it queries cURL for fetures/configuration to check if
link-time [run-time] and compile-time SSL backends match. In our case it
didn't manage to figure SSL backend at compile-time.
We explicitly select that we are using OpenSSL.
Signed-off-by: David Abdurachmanov <David.Abdurachmanov@cern.ch>
(cherry picked from commit fa66506)
We have to point PycURL to correct OpenSSL installation directory otherwise it attempts to use system path. On some machines openssl-devel package was not installed triggering compliation failures. Signed-off-by: David Abdurachmanov <David.Abdurachmanov@cern.ch> (cherry picked from commit b202e77)
|
A new Pull Request was created by @davidlt for branch IB/CMSSW_8_0_X/gcc530. @cmsbuild, @smuzaffar, @Degano, @iahmad-khan, @davidlange6 can you please review it and eventually sign? Thanks. |
|
@smuzaffar these are commits from CMSSW_8_1_X. |
|
cmsbuild, please test |
|
The tests are being triggered in jenkins. |
|
-1 Tested at: a42bf81 ---> test runtestTqafTopEventSelection had ERRORS you can see the results of the tests here: |
|
@davidlt Where those error unrelated? Shall we test again? |
|
These changes are already in production for the last few weeks (in CMSSW_8_1_X). None of the failures are related to the change. |
|
please test |
|
The tests are being triggered in jenkins. |
cmsbuild
added
tests-pending
tests-started
and removed
tests-rejected
tests-pending
labels
|
-1 Tested at: a42bf81 ---> test DetectorDescriptionRegressionTestDOMCount had ERRORS you can see the results of the tests here: |
|
this is already in 81X and errors are not related to this PR. So safe to merge this |
|
+externals |
cmsbuild
added
externals-approved
fully-signed
and removed
externals-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_8_0_X/gcc530 IBs (but tests are reportedly failing). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar |
|
merge |
The following changes are from CMSSW_8_1_X to resolve:
More details are available in the commit messages. We have noticed that CRAB3 still uses mixed binaries and triggering this issue.