Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testing PUID trained with fixed variables definitions #2390

Conversation

iahmad-khan
Copy link
Contributor

Fixes #2385

@iahmad-khan
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 13, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/cmsdist-test-pr/238/console

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @iahmad-khan (Ijaz ahmad khan) for branch IB/CMSSW_8_1_X/stable.

@cmsbuild, @smuzaffar, @Degano, @iahmad-khan, @davidlange6 can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@cmsbuild
Copy link
Contributor

-1

Tested at: dbb8994

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2390/238/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

  • RelVals:

When I ran the RelVals I found an error in the following worklfows:
1000.0 step1

DAS Error
1001.0 step1
DAS Error

@smuzaffar
Copy link
Contributor

only new files, external package build went fine.

@smuzaffar smuzaffar merged commit df0db65 into cms-sw:IB/CMSSW_8_1_X/stable Jul 13, 2016
@slava77
Copy link
Contributor

slava77 commented Jul 15, 2016

@iahmad-khan @smuzaffar
please apply the same change to 80X as well.

The data files are needed for
cms-sw/cmssw#15211 ( the 15211 will not be merged for a while) can be used for analysis recipes and eventually in a miniAOD when the new version is cut.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants