Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backport of Sherpa v2.2.1 #2760

Merged

Conversation

pmillet
Copy link
Contributor

@pmillet pmillet commented Jan 11, 2017

As discussed in GEN technical meeting: backport of newest Sherpa version v2.2.1, which is already present in 81X and 90X.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @pmillet for branch IB/CMSSW_7_1_X/stable.

@cmsbuild, @smuzaffar, @iahmad-khan, @davidlange6 can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@smuzaffar
Copy link
Contributor

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 11, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/cmsdist-test-pr/468/console

@cmsbuild
Copy link
Contributor

-1

Tested at: 6469aea

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2760/468/summary.html

I found follow errors while testing this PR

Failed tests: AddOn

  • AddOn:

I found errors in the following addon tests:

cmsRun /cvmfs/cms-ib.cern.ch/week0/slc6_amd64_gcc481/cms/cmssw/CMSSW_7_1_X_2017-01-08-0800/src/PhysicsTools/PatAlgos/test/IntegrationTest_cfg.py : FAILED - time: date Wed Jan 11 10:37:45 2017-date Wed Jan 11 10:37:14 2017 s - exit: 16640

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

@pmillet
Copy link
Contributor Author

pmillet commented Jan 11, 2017

I'm a bit puzzled by this. It seemed to work fine when I tried building Sherpa. Also I can't make sense of the error message. Is it related to Sherpa?

@davidlt
Copy link
Contributor

davidlt commented Jan 11, 2017

According to the page CMSSW_7_1_X_2017-01-08-0800 had all add-on tests passed. If only Sherpa was updated one could assume that it could be a culprit. Someone needs to investigate.

@pmillet
Copy link
Contributor Author

pmillet commented Jan 11, 2017

I'll test building it again and report the result.

@smuzaffar
Copy link
Contributor

I have forced re-built 71X IB today to see it this addOn test is failing in IB too
https://cmssdt.cern.ch/SDT/html/showIB.html

@smuzaffar
Copy link
Contributor

@cmsbuild, please test
addOn tests works fine in IB, may be it was glitch during the previous run

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 11, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/cmsdist-test-pr/470/console

@cmsbuild
Copy link
Contributor

-1

Tested at: 6469aea

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2760/470/summary.html

I found follow errors while testing this PR

Failed tests: AddOn

  • AddOn:

I found errors in the following addon tests:

cmsRun /cvmfs/cms-ib.cern.ch/week0/slc6_amd64_gcc481/cms/cmssw-patch/CMSSW_7_1_X_2017-01-11-1100/src/PhysicsTools/PatAlgos/test/IntegrationTest_cfg.py : FAILED - time: date Wed Jan 11 16:12:43 2017-date Wed Jan 11 16:12:11 2017 s - exit: 16640

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

@smuzaffar
Copy link
Contributor

I can run the failing addOn test in my local build.
@davidlange6, if every thing else look good for this PR then I would suggest that merge it and see how it behaves in next IB ?

@pmillet
Copy link
Contributor Author

pmillet commented Jan 11, 2017

I tried building it again locally. Did not see any problem.

@smuzaffar
Copy link
Contributor

@davidlange6 , this is failing due to some issue with cmsdist PR testing (still not understood why). I have built full cmssw 71X IB locally with openloop and sherpa updated and failing addOn works there.

@pmillet
Copy link
Contributor Author

pmillet commented Jan 17, 2017

@davidlange6 Should we continue with @smuzaffar suggestion or try something different?

@smuzaffar smuzaffar merged commit dceb491 into cms-sw:IB/CMSSW_7_1_X/stable Jan 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants