pip package development #2797
pip package development #2797
Conversation
…ere is a special character in the pip package name)
|
A new Pull Request was created by @davidlange6 (David Lange) for branch IB/CMSSW_9_0_X/gcc530. @cmsbuild, @smuzaffar, @iahmad-khan, @davidlange6 can you please review it and eventually sign? Thanks. |
|
please test |
|
The tests are being triggered in jenkins. |
|
-1 Tested at: 3bd1a90
I found an error when building: + for f in '$(ls $SOURCE)' + '[' -e /build/cmsbld/jenkins-workarea/workspace/cmsdist-test-pr/testBuildDir/tmp/BUILDROOT/5c58d42c0d46539ecc3c484fb993d151/opt/cmssw/slc6_amd64_gcc530/external/py2-pippkgs/2.0/lib/python2.7/site-packages/entrypoints-0.2.2.dist-info ']' + echo ' Duplicate file found: entrypoints-0.2.2.dist-info' Duplicate file found: entrypoints-0.2.2.dist-info + exit 1 error: Bad exit status from /build/cmsbld/jenkins-workarea/workspace/cmsdist-test-pr/testBuildDir/tmp/rpm-tmp.okmxGF (%install) RPM build errors: Bad exit status from /build/cmsbld/jenkins-workarea/workspace/cmsdist-test-pr/testBuildDir/tmp/rpm-tmp.okmxGF (%install) You can see the results of the tests here: |
|
weird that I didn't see this locally.. |
|
ok, now I can reproduce.. investigating. |
|
Pull request #2797 was updated. |
|
please test |
|
The tests are being triggered in jenkins. |
|
abort |
|
Jenkins tests are aborted. |
|
i fooled myself into thinking it worked locally - but not yet the case |
|
Pull request #2797 was updated. |
|
please test |
|
The tests are being triggered in jenkins. |
|
Comparison job queued. |
|
@smuzaffar - any issues you see? |
build-with-pip.file
Outdated
| %define my_name %(echo %n | cut -f2 -d-) | ||
| %endif | ||
|
|
There was a problem hiding this comment.
I would have done
%if "%{?pip_name:set}" != "set"
%define pip_name %(echo %n | cut -d- -f2-5)
%endif
and use pip_name in the rest of the file (instead of my_name).
|
yes, that is better.
… On Feb 2, 2017, at 2:54 PM, Malik Shahzad Muzaffar ***@***.***> wrote:
@smuzaffar commented on this pull request.
In build-with-pip.file:
> %define my_name %(echo %n | cut -f2 -d-)
+%endif
+
I would have done
%if "%{?pip_name:set}" != "set"
%define pip_name %(echo %n | cut -d- -f2-5)
%endif
and use pip_name in the rest of the file (instead of my_name).
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
py2-pippkgs.spec
Outdated
| # https://github.com/jupyter/jupyter_core/issues/55 | ||
| #backports is an example directory that can have multiple packages inside | ||
| if [ $f != "backports" && $f != "jupyter.py" ] ; then | ||
| echo " Duplicate file found: $f" |
There was a problem hiding this comment.
so there are multiple package providing jupyter.py? May be better to update one package to delete its jupyter.py after the build.
|
On Feb 2, 2017, at 3:02 PM, Malik Shahzad Muzaffar ***@***.***> wrote:
@smuzaffar commented on this pull request.
In py2-pippkgs.spec:
> @@ -18,9 +67,14 @@ for pkg in %builddirectpkgreqs ; do
if [ -d $SOURCE ] ; then
echo "Checking for duplicates ...."
for f in $(ls $SOURCE) ; do
- if [ -e %{i}/$PYTHON_LIB_SITE_PACKAGES/$f ] ; then
- echo " Duplicate file found: $f"
- exit 1
+ if [ -e %{i}/$PYTHON_LIB_SITE_PACKAGES/$f ] ; then
+ # jupyter/jupyter_core#55
+ #backports is an example directory that can have multiple packages inside
+ if [ $f != "backports" && $f != "jupyter.py" ] ; then
+ echo " Duplicate file found: $f"
so there are multiple package providing jupyter.py? May be better to update one package to delete its jupyter.py after the build.
ok, will think about that - I documented the github discussion on the topic
… —
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
Comparison is ready The workflows 1003.0, 1001.0, 1000.0, 140.53, 136.731, 4.22 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons |
|
Pull request #2797 was updated. |
|
please test |
|
The tests are being triggered in jenkins. |
|
Comparison job queued. |
allow pip package name to differ from rpm spec file name in case of special characters in the pip package name
add python stack for jupyter
I need to add a follow on commit that removes some now obsolete tool files and tools from cmssw tool conf before testing