Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade pythia8 to 223 with a patch #2812

Merged
merged 1 commit into from Feb 17, 2017

Conversation

mkirsano
Copy link
Contributor

@mkirsano mkirsano commented Feb 7, 2017

No description provided.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 7, 2017

A new Pull Request was created by @mkirsano (Mikhail Kirsanov) for branch IB/CMSSW_9_0_X/gcc530.

@cmsbuild, @smuzaffar, @iahmad-khan, @davidlange6 can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@smuzaffar
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 7, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/17679/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 7, 2017

-1

Tested at: e8eaadc

  • Build:

I found an error when building:

* The action "install-external+sigcpp-toolfile+1.0-cms" was not completed successfully because The following dependencies could not complete:
build-external+sigcpp-toolfile+1.0-cms
* The action "install-external+sigcpp+2.6.2-cms" was not completed successfully because The following dependencies could not complete:
build-external+sigcpp+2.6.2-cms
* The action "build-external+sigcpp-toolfile+1.0-cms" was not completed successfully because The following dependencies could not complete:
install-external+sigcpp+2.6.2-cms


You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2812/17679/summary.html

@mkirsano
Copy link
Contributor Author

mkirsano commented Feb 8, 2017

These test fails are obviously unrelated

@smuzaffar
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 8, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/17695/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 8, 2017

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 8, 2017

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 8, 2017

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2812/17695/summary.html

The workflows 1003.0, 1001.0, 1000.0, 140.53, 136.731, 4.22 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons

@davidlange6
Copy link
Contributor

Hi @mkirsano - the changes in this proposed patch are now part of pythia8?

@mkirsano
Copy link
Contributor Author

mkirsano commented Feb 9, 2017

These changes are in pythia8 repo but they are not released. The idea is to play a bit with the modified code in CMS before the next pythia8 release.

@davidlange6 davidlange6 merged commit ea424be into cms-sw:IB/CMSSW_9_0_X/gcc530 Feb 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants