Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backport of Sherpa 2.2.2 #2856

Conversation

pmillet
Copy link
Contributor

@pmillet pmillet commented Feb 22, 2017

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @pmillet for branch IB/CMSSW_7_1_X/stable.

@cmsbuild, @smuzaffar, @iahmad-khan, @davidlange6 can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@pmillet
Copy link
Contributor Author

pmillet commented Feb 24, 2017

@smuzaffar
Copy link
Contributor

#2855 is in DEVEL IBs, can you please test it and see if it works as expected? After that it should first go to normal 90X IBs and then to 71X.

@pmillet
Copy link
Contributor Author

pmillet commented Feb 24, 2017

I tested building and using it in 71X. It seems to work fine.
For tests in 90X see #2855.

@pmillet
Copy link
Contributor Author

pmillet commented Mar 2, 2017

I did some tests in IB/CMSSW_9_0_X/gcc530 and everything seems to work fine. Can we proceed with this?

@perrozzi
Copy link

perrozzi commented Mar 2, 2017

for what it matters, GEN strongly supports this update

@pmillet
Copy link
Contributor Author

pmillet commented Mar 8, 2017

@smuzaffar any news on this?

@smuzaffar
Copy link
Contributor

cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 8, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/18237/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 8, 2017

-1

Tested at: 3dbb4fe

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2856/18237/summary.html

I found follow errors while testing this PR

Failed tests: AddOn

  • AddOn:

I found errors in the following addon tests:

cmsRun /cvmfs/cms-ib.cern.ch/week0/slc6_amd64_gcc481/cms/cmssw/CMSSW_7_1_X_2017-03-05-0000/src/PhysicsTools/PatAlgos/test/IntegrationTest_cfg.py : FAILED - time: date Wed Mar 8 11:42:21 2017-date Wed Mar 8 11:41:53 2017 s - exit: 16640

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 8, 2017

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 8, 2017

@pmillet
Copy link
Contributor Author

pmillet commented Mar 8, 2017

this does not seem to be related to sherpa

@smuzaffar
Copy link
Contributor

please test
Lets try again but agree the failure does not look related to this PR.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 8, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/18244/console

@smuzaffar
Copy link
Contributor

@pmillet, In last week's ORP, there was a question about the validation of Sherpa 2.2.2 in 90X.
@davidlange6 , did you get any answer?

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 8, 2017

-1

Tested at: 3dbb4fe

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2856/18244/summary.html

I found follow errors while testing this PR

Failed tests: AddOn

  • AddOn:

I found errors in the following addon tests:

cmsRun /cvmfs/cms-ib.cern.ch/week0/slc6_amd64_gcc481/cms/cmssw-patch/CMSSW_7_1_X_2017-03-08-1100/src/PhysicsTools/PatAlgos/test/IntegrationTest_cfg.py : FAILED - time: date Wed Mar 8 16:20:36 2017-date Wed Mar 8 16:20:10 2017 s - exit: 16640

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 8, 2017

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 8, 2017

@pmillet
Copy link
Contributor Author

pmillet commented Mar 8, 2017

@smuzaffar @davidlange6 The question did not reach me. If it was not answered please ask. Not sure what to make out of this failing test though.

@smuzaffar
Copy link
Contributor

the reason behind the error in PR tests is that in IB some datafiles Geometry/* are picked up from cmssw/src/Geometry/ path while in PR tests the CMSSW_SEARCH_PATH become

$CMSSW_BASE/src:$CMSSW_BASE/external/slc6_amd64_gcc481/data:$CMSSW_RELEASE_BASE/src:$CMSSW_RELEASE_BASE/external/slc6_amd64_gcc481/data

soin this case, geometry datafiles are picked up from external area and there is good change that these files are not in sync.

@smuzaffar
Copy link
Contributor

please test
I have fixed the login for PR testing to scram setup only those tools which are changed. Hopefully this should fix the cmsswdata issue

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 8, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/18260/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 8, 2017

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 8, 2017

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 8, 2017

@davidlange6
Copy link
Contributor

yes, its answered- i'll merge this

@davidlange6 davidlange6 merged commit 33b4489 into cms-sw:IB/CMSSW_7_1_X/stable Mar 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants