To avoid latency disable uniq sorting by default and made it optional #2898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A new Pull Request was created by @vkuznet (Valentin Kuznetsov) for branch IB/CMSSW_9_1_X/gcc530. @cmsbuild, @smuzaffar, @iahmad-khan, @davidlange6 can you please review it and eventually sign? Thanks. |
|
please test |
|
@smuzaffar, Shahzad could you please trigger tests build, I submit PR early last week. |
|
please also update dasgoclient.spec |
|
Pull request #2898 was updated. |
|
@cmsbuild, please test |
|
The tests are being triggered in jenkins. |
|
Comparison job queued. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found that recent change to use unique results may significantly hurt performance for large queries, such as
file dataset=/Neutrino_E-10_gun/RunIISpring15PrePremix-PUMoriond17_80X_mcRun2_asymptotic_2016_TrancheIV_v2-v2/GEN-SIM-DIGI-RAWwhich returns 125K+ LFNs. Sorting of such list will take a minute and not really necessary. While for other DAS queries, such as site for given dataset, it is required since users want to see final set of sites, while results shows all possible replicas. As compromise I made unique flag and made it optional. By default sorting/uniq is disabled to provide ability to look-up results as fast as possible.