Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added OpenMPI support for sherpa #3167

Merged

Conversation

pmillet
Copy link
Contributor

@pmillet pmillet commented Jul 18, 2017

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 18, 2017

A new Pull Request was created by @pmillet for branch IB/CMSSW_7_1_X/stable.

@cmsbuild, @smuzaffar, @mrodozov, @davidlange6 can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@smuzaffar
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 18, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/21583/console

@cmsbuild
Copy link
Contributor

-1

Tested at: f296865

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3167/21583/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests

  • Unit Tests:

I found errors in the following unit tests:

---> test TestRunnerDataFormatsFWLite had ERRORS
---> test testCoralSQLPrinting had ERRORS

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3167/21583/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 13
  • DQMHistoTests: Total histograms compared: 842166
  • DQMHistoTests: Total failures: 3470
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 838228
  • DQMHistoTests: Total skipped: 468
  • DQMHistoTests: Total Missing objects: 0
  • Checked 51 log files, 14 edm output root files, 13 DQM output files

@smuzaffar
Copy link
Contributor

please test
trying again as these unit tests are not failing in 71X IBs

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 19, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/21599/console

@cmsbuild
Copy link
Contributor

-1

Tested at: f296865

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3167/21599/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests

  • Unit Tests:

I found errors in the following unit tests:

---> test TestRunnerDataFormatsFWLite had ERRORS
---> test testCoralSQLPrinting had ERRORS

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3167/21599/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 13
  • DQMHistoTests: Total histograms compared: 842166
  • DQMHistoTests: Total failures: 2801
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 838897
  • DQMHistoTests: Total skipped: 468
  • DQMHistoTests: Total Missing objects: 0
  • Checked 51 log files, 14 edm output root files, 13 DQM output files

@pmillet
Copy link
Contributor Author

pmillet commented Jul 19, 2017

this does not seem to be related to sherpa, does it?
not sure if the updated autoconf could be the culprit

@pmillet
Copy link
Contributor Author

pmillet commented Jul 21, 2017

@smuzaffar anything we can do about this?

@davidlange6
Copy link
Contributor

davidlange6 commented Jul 21, 2017 via email

@smuzaffar
Copy link
Contributor

+externals
due to autoconf this PR rebuild many externals including root which made checkdeps to checkout 80% of cmssw and ran all tests. These failure do not relate to this update.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_7_1_X/stable IBs (but tests are reportedly failing). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@smuzaffar
Copy link
Contributor

backport of #3130

@cms-sw cms-sw deleted a comment from cmsbuild Jul 21, 2017
@cms-sw cms-sw deleted a comment from cmsbuild Jul 21, 2017
@cms-sw cms-sw deleted a comment from cmsbuild Jul 21, 2017
@cms-sw cms-sw deleted a comment from cmsbuild Jul 21, 2017
@davidlange6
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit 5f3251a into cms-sw:IB/CMSSW_7_1_X/stable Jul 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants