Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tensorflow-sources.spec #3361

Merged
merged 4 commits into from Aug 25, 2017
Merged

Conversation

davidlange6
Copy link
Contributor

@davidlange6 davidlange6 commented Aug 24, 2017

use sse3 as suggested in cms-sw/cmssw#19893

use sse3 as suggested in #19893
@davidlange6
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 24, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/22480/console

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @davidlange6 (David Lange) for branch IB/CMSSW_9_3_X/gcc630.

@cmsbuild, @smuzaffar, @mrodozov can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@davidlt
Copy link
Contributor

davidlt commented Aug 24, 2017

sse3 is not a valid option for -march. The lowest you can go is prescott (the first one to enable SSE3). Another safe alternative could be core2. Later on, e.g. nehalem, already brings SSE4.2 which is probably still not available on every worker node (should be minority).

@cmsbuild
Copy link
Contributor

-1

Tested at: ca91507

  • Build:

I found an error when building:

TMPDIR=/build/cmsbld/jenkins-workarea/workspace/ib-any-integration/testBuildDir/tmp \
/build/cmsbld/jenkins-workarea/workspace/ib-any-integration/testBuildDir/slc6_amd64_gcc630/external/gcc/6.3.0/bin/gcc -U_FORTIFY_SOURCE -fstack-protector -Wall -B/build/cmsbld/jenkins-workarea/workspace/ib-any-integration/testBuildDir/slc6_amd64_gcc630/external/gcc/6.3.0/bin -B/usr/bin -Wunused-but-set-parameter -Wno-free-nonheap-object -fno-omit-frame-pointer -g0 -O2 '-D_FORTIFY_SOURCE=1' -DNDEBUG -ffunction-sections -fdata-sections -g0 -MD -MF bazel-out/host/bin/external/nasm/_objs/nasm/external/nasm/macros.d -DHAVE_SNPRINTF -iquote external/nasm -iquote bazel-out/host/genfiles/external/nasm -iquote external/bazel_tools -iquote bazel-out/host/genfiles/external/bazel_tools -isystem external/bazel_tools/tools/cpp/gcc3 -w '-std=c99' -fno-canonical-system-headers -Wno-builtin-macro-redefined '-D__DATE__="redacted"' '-D__TIMESTAMP__="redacted"' '-D__TIME__="redacted"' -c external/nasm/macros.c -o bazel-out/host/bin/external/nasm/_objs/nasm/external/nasm/macros.o)
____Building complete.
Target //tensorflow/tools/pip_package:build_pip_package failed to build
____Elapsed time: 5.281s, Critical Path: 1.04s
error: Bad exit status from /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/testBuildDir/tmp/rpm-tmp.5HvrUW (%build)


RPM build errors:
Bad exit status from /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/testBuildDir/tmp/rpm-tmp.5HvrUW (%build)



You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3361/22480/summary.html

@davidlange6
Copy link
Contributor Author

hi @davidlt - thanks - i couldn't find definitive documentation on this (undoubtedly because I didn't search for the right thing)

@cmsbuild
Copy link
Contributor

Pull request #3361 was updated.

@davidlange6
Copy link
Contributor Author

please test

(I'm trying to match what we did with openblas)

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 24, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/22483/console

@cmsbuild
Copy link
Contributor

-1

Tested at: b173fd5

  • Build:

I found an error when building:

* The action "build-external+tensorflow-c+1.1.0-cms" was not completed successfully because The following dependencies could not complete:
install-external+tensorflow-sources+1.1.0-cms
* The action "build-external+tensorflow-sources+1.1.0-cms" was not completed successfully because Failed to build tensorflow-sources. Log file in /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/testBuildDir/BUILD/slc6_amd64_gcc630/external/tensorflow-sources/1.1.0-cms/log. Final lines of the log file:
TMPDIR=/build/cmsbld/jenkins-workarea/workspace/ib-any-integration/testBuildDir/tmp \
/build/cmsbld/jenkins-workarea/workspace/ib-any-integration/testBuildDir/slc6_amd64_gcc630/external/gcc/6.3.0/bin/gcc -U_FORTIFY_SOURCE -fstack-protector -Wall -B/build/cmsbld/jenkins-workarea/workspace/ib-any-integration/testBuildDir/slc6_amd64_gcc630/external/gcc/6.3.0/bin -B/usr/bin -Wunused-but-set-parameter -Wno-free-nonheap-object -fno-omit-frame-pointer -g0 -O2 '-D_FORTIFY_SOURCE=1' -DNDEBUG -ffunction-sections -fdata-sections '-march=penryn' '-std=c++0x' '-march=penryn' -MD -MF bazel-out/local-opt/bin/external/farmhash_archive/_objs/farmhash/external/farmhash_archive/src/farmhash.pic.d '-frandom-seed=bazel-out/local-opt/bin/external/farmhash_archive/_objs/farmhash/external/farmhash_archive/src/farmhash.pic.o' -fPIC -iquote external/farmhash_archive -iquote bazel-out/local-opt/genfiles/external/farmhash_archive -iquote external/bazel_tools -iquote bazel-out/local-opt/genfiles/external/bazel_tools -isystem external/farmhash_archive/src -isystem bazel-out/local-opt/genfiles/external/farmhash_archive/src -isystem external/bazel_tools/tools/cpp/gcc3 -fno-canonical-system-headers -Wno-builtin-macro-redefined '-D__DATE__="redacted"' '-D__TIMESTAMP__="redacted"' '-D__TIME__="redacted"' -c external/farmhash_archive/src/farmhash.cc -o bazel-out/local-opt/bin/external/farmhash_archive/_objs/farmhash/external/farmhash_archive/src/farmhash.pic.o): com.google.devtools.build.lib.shell.BadExitStatusException: Process exited with status 1.
external/farmhash_archive/src/farmhash.cc:1:0: error: bad value (penryn) for -march= switch
// Copyright (c) 2014 Google, Inc.

>>>>>>>>> # @png_archive//:png [action 'Compiling external/png_archive/pngwutil.c [for host]']
(cd /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/testBuildDir/BUILD/slc6_amd64_gcc630/external/tensorflow-sources/1.1.0-cms/tensorflow-1.1.0/dud/736eeeef7a947940c9aa14ad866d1346/execroot/tensorflow-1.1.0 && \
exec env - \


You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3361/22483/summary.html

@cmsbuild
Copy link
Contributor

Pull request #3361 was updated.

@davidlange6
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 24, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/22485/console

@cmsbuild
Copy link
Contributor

Pull request #3361 was updated.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@davidlange6
Copy link
Contributor Author

merge

@cmsbuild cmsbuild merged commit ded623b into IB/CMSSW_9_3_X/gcc630 Aug 25, 2017
@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3361/22485/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 26
  • DQMHistoTests: Total histograms compared: 2653934
  • DQMHistoTests: Total failures: 209
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2653536
  • DQMHistoTests: Total skipped: 189
  • DQMHistoTests: Total Missing objects: 0
  • Checked 107 log files, 14 edm output root files, 26 DQM output files

@davidlt
Copy link
Contributor

davidlt commented Aug 25, 2017

@smuzaffar smuzaffar deleted the davidlange6-patch-1 branch August 29, 2017 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants