Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added patch for decay of K0 and antiK0 #3505

Merged
merged 1 commit into from Nov 21, 2017

Conversation

civanch
Copy link
Contributor

@civanch civanch commented Oct 17, 2017

This patch for K0 and antiK0 decay should fix XeXE production but not change simulation histories.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @civanch (Vladimir Ivantchenko) for branch IB/CMSSW_9_3_X/gcc630.

@cmsbuild, @smuzaffar, @gudrutis, @mrodozov can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@civanch
Copy link
Contributor Author

civanch commented Oct 17, 2017

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 17, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/23822/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3505/23822/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 26
  • DQMHistoTests: Total histograms compared: 2708283
  • DQMHistoTests: Total failures: 233
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2707863
  • DQMHistoTests: Total skipped: 187
  • DQMHistoTests: Total Missing objects: 0
  • Checked 107 log files, 9 edm output root files, 26 DQM output files

@mrodozov
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_9_3_X/gcc630 IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

@mrodozov mrodozov mentioned this pull request Oct 18, 2017
@civanch
Copy link
Contributor Author

civanch commented Oct 18, 2017

@davidlange6 , the fix help to keep sim histories.

@davidlange6
Copy link
Contributor

hi @civanch - do we need both this and #3510?

@civanch
Copy link
Contributor Author

civanch commented Nov 7, 2017

Hi @davidlange6 , we have production gcc/architecture and another one, I would keep cmsdist the same for both - it is more clear for the long term maintenance. So, to me an optimal solution is to merge both PRs.

@davidlange6
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit b7dfd12 into cms-sw:IB/CMSSW_9_3_X/gcc630 Nov 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants