-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move Lightweight Trained Neural Network version to 2.4 #3562
Move Lightweight Trained Neural Network version to 2.4 #3562
Conversation
A new Pull Request was created by @mrodozov for branch IB/CMSSW_10_0_X/gcc630. @cmsbuild, @smuzaffar, @gudrutis, @mrodozov can you please review it and eventually sign? Thanks. |
please test |
The tests are being triggered in jenkins. |
lwtnn.spec
Outdated
Requires: eigen boost | ||
Patch0: lwtnn-1.0-boost-fix |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The patch is not removed in CMSDIST. Please remove it.
lwtnn.spec
Outdated
Source: https://github.com/lwtnn/lwtnn/archive/v%{realversion}.tar.gz | ||
BuildRequires: py2-pkgconfig | ||
BuildRequires: py2-pkgconfig ninja cmake |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove py2-pkgconfig
as it's not used anymore. It was used for old makefiles: makefile:CXXFLAGS += $(shell pkg-config eigen3 --cflags)
please abort |
Jenkins tests are aborted. |
a4a0ec1
to
9de2fdd
Compare
Pull request #3562 was updated. |
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready There are some workflows for which there are errors in the baseline: Comparison Summary:
|
Update lwtnn version to 2.4