Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Lightweight Trained Neural Network version to 2.4 #3562

Merged

Conversation

mrodozov
Copy link
Contributor

@mrodozov mrodozov commented Nov 7, 2017

Update lwtnn version to 2.4

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 7, 2017

A new Pull Request was created by @mrodozov for branch IB/CMSSW_10_0_X/gcc630.

@cmsbuild, @smuzaffar, @gudrutis, @mrodozov can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@mrodozov
Copy link
Contributor Author

mrodozov commented Nov 7, 2017

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 7, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/24233/console

lwtnn.spec Outdated
Requires: eigen boost
Patch0: lwtnn-1.0-boost-fix
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The patch is not removed in CMSDIST. Please remove it.

lwtnn.spec Outdated
Source: https://github.com/lwtnn/lwtnn/archive/v%{realversion}.tar.gz
BuildRequires: py2-pkgconfig
BuildRequires: py2-pkgconfig ninja cmake
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove py2-pkgconfig as it's not used anymore. It was used for old makefiles: makefile:CXXFLAGS += $(shell pkg-config eigen3 --cflags)

@mrodozov
Copy link
Contributor Author

mrodozov commented Nov 7, 2017

please abort

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 7, 2017

Jenkins tests are aborted.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 7, 2017

Pull request #3562 was updated.

@mrodozov
Copy link
Contributor Author

mrodozov commented Nov 7, 2017

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 7, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/24238/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 7, 2017

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 7, 2017

Comparison job queued.

@smuzaffar smuzaffar merged commit d485be6 into cms-sw:IB/CMSSW_10_0_X/gcc630 Nov 7, 2017
@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 7, 2017

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3562/24238/summary.html

There are some workflows for which there are errors in the baseline:
10042.0 step 5
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Comparison Summary:

  • No significant changes to the logs found
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 19326 differences found in the comparisons
  • DQMHistoTests: Total files compared: 26
  • DQMHistoTests: Total histograms compared: 2755261
  • DQMHistoTests: Total failures: 88865
  • DQMHistoTests: Total nulls: 5
  • DQMHistoTests: Total successes: 2666222
  • DQMHistoTests: Total skipped: 169
  • DQMHistoTests: Total Missing objects: 0
  • 'Traceback (most recent call last):\n File "/cvmfs/cms-ib.cern.ch/nweek-02497/slc6_amd64_gcc630/cms/cmssw/CMSSW_10_0_X_2017-11-06-1100/bin/slc6_amd64_gcc630/dqmMemoryStats.py", line 126, in \n for (fn, v) in reader.read_objects():\n File "/cvmfs/cms-ib.cern.ch/week1/slc6_amd64_gcc630/cms/cmssw-patch/CMSSW_10_0_X_2017-11-06-2300/python/DQMServices/FileIO/DQM.py", line 39, in read_objects_dqmio\n object_type = self.DQMIO_TYPES[indices.Type]\nIndexError: list index out of range\n') ('', 'Traceback (most recent call last):\n File "/cvmfs/cms-ib.cern.ch/nweek-02497/slc6_amd64_gcc630/cms/cmssw/CMSSW_10_0_X_2017-11-06-1100/bin/slc6_amd64_gcc630/dqmMemoryStats.py", line 126, in \n for (fn, v) in reader.read_objects():\n File "/cvmfs/cms-ib.cern.ch/week1/slc6_amd64_gcc630/cms/cmssw-patch/CMSSW_10_0_X_2017-11-06-2300/python/DQMServices/FileIO/DQM.py", line 39, in read_objects_dqmio\n object_type = self.DQMIO_TYPES[indices.Type]\nIndexError: list index out of range\n') SUMMARY DQMHistoSizes: Histogram bins added: 0.0 ( 22 files compared)
  • Checked 107 log files, 8 edm output root files, 26 DQM output files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants