update Intel tools for CMSSW 10.0.x #3610
Conversation
|
A new Pull Request was created by @fwyzard (Andrea Bocci) for branch IB/CMSSW_10_0_X/gcc630. @cmsbuild, @smuzaffar, @gudrutis, @mrodozov can you please review it and eventually sign? Thanks. |
|
@cmsbuild, please test |
|
The tests are being triggered in jenkins. |
fwyzard
changed the title
|
@cmsbuild, please test |
|
The tests are being triggered in jenkins. |
|
Pull request #3610 was updated. |
fwyzard
force-pushed
the
Intel_Tools_2018.0_for_IB/CMSSW_10_0_X/gcc630
branch
from
9a62c4f
to
8ebdd0f
Compare
|
@cmsbuild, please test |
|
The tests are being triggered in jenkins. |
|
Pull request #3610 was updated. |
|
Comparison job queued. |
|
Comparison is ready There are some workflows for which there are errors in the baseline: Comparison Summary:
|
|
@fwyzard , looks like c++17 change (for gcc630) did not go well with boost serialization I would sugegst to revert it to c++1z for gcc630 |
|
Yup, we need to keep |
|
Does the serialisation code take the flags from the llvm-cxxcompiler tool ? <flags REM_CXXFLAGS="-std=c++17"/>
<flags CXXFLAGS="-std=c++1z"/>to llvm-cxxcompiler ? |
|
It does a messy thing. It reads original GCC flags and then modifies them enough to make Clang happy (I was against that). Do you (or some tool) explicitly need |
|
ICC/ICPC (Intel compiler) understands <flags REM_CXXFLAGS="-std=c++1z"/>
<flags CXXFLAGS="-std=c++17"/> |
|
condformats_serialization_generate.py script calls |
|
@fwyzard, yes we can add it in icc toolfiles. By the way, will .cc files compiled with c++1z and .cu with c++17 work together? Can you test this and add PR? |
Is there no way to get the LLVM flags for a package, even if the compiler is GCC ? ? |
|
|
|
They didn't want to that originally and was already suggested to them (years ago). |
|
@davidlt, who were the original author ? do you remember what was the objection ? |
|
@smuzaffar actually it looks like scram explicitly passes the flags to the tool: # CondFormat Serialization generation
define generate_CondSerialization
@$(startlog_$(2))[ -d $(@D) ] || $(CMD_mkdir) -p $(@D) &&\
$(CMD_echo) ">> Generating CondFormat Serialization code from header file $< " &&\
$(VERB_ECHO) $(COND_SERIALIZATION_SCRIPT) --output $(LOCALTOP)/$@ --package $(dir $3) -- $(call AdjustFlags,$1,,CPPFLAGS CXXFLAGS) &&\
( $(COND_SERIALIZATION_SCRIPT) --output $(LOCALTOP)/$@ --package $(dir $3) -- $(call AdjustFlags,$1,,CPPFLAGS CXXFLAGS) || ($(CMD_rm) -f $@ && exit 1)) $(endlog_$(2))
endefHow would one tell scram to use the llvm flags instead ? |
|
@fwyzard, ah right ..... if scram flags are not passed then script runs |
|
Can SCRAM itself call
scram b echo_CondFormatsPACKAGE_CXXFLAGS COMPILER='llvm'
to get b the right flags ?
|
|
one can (never tested , might not work due to some internal cached flags) but it would be very expensive call. |
|
FYI, @fwyzard , new build rules now allow to pass llvm-cxxcompiler flags ( cms-sw/cmssw-config@3417ef6#diff-0a86a53bf24863421e1a627d229895e1R675) to condformats_serialization_generate.py |
|
@smuzaffar nice. |
|
@fwyzard , yes that is correct. Now condformats_serialization_generate.py should receive only LLVM flags. |
Update the Intel Compiler to version 2018.0.128
Update Intel VTune to version 2018.0.2.525261
Update Intel TBB to 2018 Update 1