Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update clhep to 2.4.0.0 with cms patches #3672

Merged
merged 1 commit into from Jan 18, 2018
Merged

update clhep to 2.4.0.0 with cms patches #3672

merged 1 commit into from Jan 18, 2018

Conversation

smuzaffar
Copy link
Contributor

Reverts #3670

@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 17, 2018 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/25495/console

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for branch IB/CMSSW_10_0_X/gcc630.

@cmsbuild, @smuzaffar, @gudrutis, @mrodozov can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@cmsbuild
Copy link
Contributor

+1
Tested at: b83208e
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3672/25495/summary.html

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3672/25495/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-3672/1325.7_TTbar_13_94XNanoAODINPUT+TTbar_13_94XNanoAODINPUT+NANOEDMMC2017

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 26
  • DQMHistoTests: Total histograms compared: 2467599
  • DQMHistoTests: Total failures: 206
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2467224
  • DQMHistoTests: Total skipped: 169
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.890000000109 KiB( 22 files compared)
  • Checked 110 log files, 9 edm output root files, 26 DQM output files

@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 18, 2018 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/25502/console
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/25503/console

@cmsbuild
Copy link
Contributor

-1

Tested at: b83208e

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3672/25503/summary.html

I found follow errors while testing this PR

Failed tests: AddOn

  • AddOn:

I found errors in the following addon tests:

cmsRun /cvmfs/cms-ib.cern.ch/nweek-02507/slc6_amd64_gcc630/cms/cmssw/CMSSW_10_0_X_2018-01-17-1100/src/HLTrigger/Configuration/test/OnLine_HLT_Fake2.py realData=True globalTag=@ inputFiles=@ : FAILED - time: date Thu Jan 18 11:19:03 2018-date Thu Jan 18 11:15:27 2018 s - exit: 35584
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02507/slc6_amd64_gcc630/cms/cmssw/CMSSW_10_0_X_2018-01-17-1100/src/HLTrigger/Configuration/test/OnLine_HLT_PRef.py realData=True globalTag=@ inputFiles=@ : FAILED - time: date Thu Jan 18 11:24:06 2018-date Thu Jan 18 11:15:30 2018 s - exit: 35584
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02507/slc6_amd64_gcc630/cms/cmssw/CMSSW_10_0_X_2018-01-17-1100/src/HLTrigger/Configuration/test/OnLine_HLT_HIon.py realData=True globalTag=@ inputFiles=@ : FAILED - time: date Thu Jan 18 11:22:57 2018-date Thu Jan 18 11:15:32 2018 s - exit: 35584
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02507/slc6_amd64_gcc630/cms/cmssw/CMSSW_10_0_X_2018-01-17-1100/src/HLTrigger/Configuration/test/OnLine_HLT_GRun.py realData=False globalTag=@ inputFiles=@ : FAILED - time: date Thu Jan 18 11:25:35 2018-date Thu Jan 18 11:15:36 2018 s - exit: 35584
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02507/slc6_amd64_gcc630/cms/cmssw/CMSSW_10_0_X_2018-01-17-1100/src/HLTrigger/Configuration/test/OnLine_HLT_PRef.py realData=False globalTag=@ inputFiles=@ : FAILED - time: date Thu Jan 18 11:24:10 2018-date Thu Jan 18 11:15:43 2018 s - exit: 35584
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02507/slc6_amd64_gcc630/cms/cmssw/CMSSW_10_0_X_2018-01-17-1100/src/HLTrigger/Configuration/test/OnLine_HLT_PIon.py realData=True globalTag=@ inputFiles=@ : FAILED - time: date Thu Jan 18 11:20:15 2018-date Thu Jan 18 11:15:51 2018 s - exit: 35584
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02507/slc6_amd64_gcc630/cms/cmssw/CMSSW_10_0_X_2018-01-17-1100/src/HLTrigger/Configuration/test/OnLine_HLT_Fake.py realData=False globalTag=@ inputFiles=@ : FAILED - time: date Thu Jan 18 11:23:40 2018-date Thu Jan 18 11:15:54 2018 s - exit: 16640
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02507/slc6_amd64_gcc630/cms/cmssw/CMSSW_10_0_X_2018-01-17-1100/src/HLTrigger/Configuration/test/OnLine_HLT_HIon.py realData=False globalTag=@ inputFiles=@ : FAILED - time: date Thu Jan 18 11:23:57 2018-date Thu Jan 18 11:15:59 2018 s - exit: 35584
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02507/slc6_amd64_gcc630/cms/cmssw/CMSSW_10_0_X_2018-01-17-1100/src/HLTrigger/Configuration/test/OnLine_HLT_Fake2.py realData=False globalTag=@ inputFiles=@ : FAILED - time: date Thu Jan 18 11:23:53 2018-date Thu Jan 18 11:16:03 2018 s - exit: 35584
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02507/slc6_amd64_gcc630/cms/cmssw/CMSSW_10_0_X_2018-01-17-1100/src/HLTrigger/Configuration/test/OnLine_HLT_Fake1.py realData=False globalTag=@ inputFiles=@ : FAILED - time: date Thu Jan 18 11:23:48 2018-date Thu Jan 18 11:16:06 2018 s - exit: 16640
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02507/slc6_amd64_gcc630/cms/cmssw/CMSSW_10_0_X_2018-01-17-1100/src/HLTrigger/Configuration/test/OnLine_HLT_Fake.py realData=True globalTag=@ inputFiles=@ : FAILED - time: date Thu Jan 18 11:19:24 2018-date Thu Jan 18 11:16:13 2018 s - exit: 16640
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02507/slc6_amd64_gcc630/cms/cmssw/CMSSW_10_0_X_2018-01-17-1100/src/HLTrigger/Configuration/test/OnLine_HLT_GRun.py realData=True globalTag=@ inputFiles=@ : FAILED - time: date Thu Jan 18 11:24:28 2018-date Thu Jan 18 11:16:15 2018 s - exit: 35584
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02507/slc6_amd64_gcc630/cms/cmssw/CMSSW_10_0_X_2018-01-17-1100/src/HLTrigger/Configuration/test/OnLine_HLT_Fake1.py realData=True globalTag=@ inputFiles=@ : FAILED - time: date Thu Jan 18 11:19:25 2018-date Thu Jan 18 11:16:16 2018 s - exit: 16640
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02507/slc6_amd64_gcc630/cms/cmssw/CMSSW_10_0_X_2018-01-17-1100/src/HLTrigger/Configuration/test/OnLine_HLT_PIon.py realData=False globalTag=@ inputFiles=@ : FAILED - time: date Thu Jan 18 11:24:37 2018-date Thu Jan 18 11:16:19 2018 s - exit: 35584

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3672/25503/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-3672/1325.7_TTbar_13_94XNanoAODINPUT+TTbar_13_94XNanoAODINPUT+NANOEDMMC2017

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 26
  • DQMHistoTests: Total histograms compared: 2467599
  • DQMHistoTests: Total failures: 206
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2467224
  • DQMHistoTests: Total skipped: 169
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 1.04000000005 KiB( 22 files compared)
  • Checked 110 log files, 9 edm output root files, 26 DQM output files

@smuzaffar
Copy link
Contributor Author

@fabiocos , the addon test failures are not due to clhep. Do comparison results looks good to you? If yes then we can include new clhep for normal 10.0.X too.

@fabiocos
Copy link
Contributor

The few (minor) differences are all for RPCDigisV. This is unlikely to depend on CLHEP itself. I think we can go back to the new CLHEP in the regular build.

@smuzaffar
Copy link
Contributor Author

+externals

@smuzaffar smuzaffar merged commit a186067 into IB/CMSSW_10_0_X/gcc630 Jan 18, 2018
@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_10_0_X/gcc630 IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@smuzaffar smuzaffar deleted the revert-3670-revert-3650-clhep-2.4.0.0 branch January 22, 2018 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
externals-approved fully-signed orp-pending tests-rejected
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@smuzaffar @cmsbuild @fabiocos