Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for tkonlinesw gcc7 cleanup #3728

Merged

Conversation

mrodozov
Copy link
Contributor

@mrodozov mrodozov commented Feb 9, 2018

Fixes the compilation errors here:
https://cmssdt.cern.ch/SDT/cgi-bin/showBuildLogs.py/slc6_amd64_gcc700/www/fri/10.1-fri-11/CMSSW_10_1_X_2018-02-09-1100
that were due to removal of the previous existing patch for gcc7.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 9, 2018

A new Pull Request was created by @mrodozov (Mircho Rodozov) for branch IB/CMSSW_10_1_X/gcc630.

@cmsbuild, @smuzaffar, @gudrutis, @mrodozov can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@mrodozov
Copy link
Contributor Author

mrodozov commented Feb 9, 2018

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 9, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/25992/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 9, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 9, 2018

Comparison job queued.

@mrodozov
Copy link
Contributor Author

mrodozov commented Feb 9, 2018

+externals

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 9, 2018

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_10_1_X/gcc630 IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 9, 2018

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3728/25992/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-3728/1325.7_TTbar_13_94XNanoAODINPUT+TTbar_13_94XNanoAODINPUT+NANOEDMMC2017+HARVESTNANOAODMC2017

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 27
  • DQMHistoTests: Total histograms compared: 2464162
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2463992
  • DQMHistoTests: Total skipped: 169
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.999999999884 KiB( 22 files compared)
  • Checked 111 log files, 9 edm output root files, 27 DQM output files

@smuzaffar
Copy link
Contributor

thanks @mrodozov

@smuzaffar smuzaffar merged commit 544f0ac into cms-sw:IB/CMSSW_10_1_X/gcc630 Feb 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants