Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated bazel 0.10.0; tensorflow 1.5.0 #3747

Merged
merged 7 commits into from Mar 5, 2018
Merged

updated bazel 0.10.0; tensorflow 1.5.0 #3747

merged 7 commits into from Mar 5, 2018

Conversation

smuzaffar
Copy link
Contributor

Bazel/Tensorflow are failing for aarch64 IBs and we can not rebuilt it because of java version update which breaks bazel. This PR updates

bazel 0.10.0 which also contains fixes for new java 1.8.0
tensorflow 1.5.0
eigen commit c7dc0a897676
We need to update bazel as existing version 0.4.5 does not work with the java 1.8.0_162 (bazelbuild/bazel#4483). Bazel version 0.10.0 works with latest java but tensorflow 1.3.0 does not build with it (because of some deprecated functionality in bazel). So we propose to move to tensorflow 1.5.0.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for branch IB/CMSSW_10_1_X/gcc630.

@cmsbuild, @smuzaffar, @gudrutis, @mrodozov can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 17, 2018

The tests are being triggered in jenkins.
Using cmssw from cms-sw/cmssw#22260
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/26147/console

@cmsbuild
Copy link
Contributor

-1

Tested at: 574155f

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22260/26147/summary.html

I found follow errors while testing this PR

Failed tests: Build

  • Build:

I found an error when building:

>> Compiling edm plugin /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_1_X_2018-02-17-1100/src/PhysicsTools/HepMCCandAlgos/plugins/MCMatchCandRefSelector.cc 
>> Compiling edm plugin /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_1_X_2018-02-17-1100/src/PhysicsTools/HepMCCandAlgos/plugins/GenParticleProducer.cc 
>> Compiling edm plugin /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_1_X_2018-02-17-1100/src/PhysicsTools/HepMCCandAlgos/plugins/PDFWeightsTest.cc 
>> Compiling edm plugin /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_1_X_2018-02-17-1100/src/PhysicsTools/HepMCCandAlgos/plugins/MCTruthDeltaRMatcher.cc 
/build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_1_X_2018-02-17-1100/src/PhysicsTools/TensorFlow/src/TBBSession.cc: In member function 'virtual tensorflow::Status tensorflow::TBBSession::Run(const tensorflow::RunOptions&, const NamedTensorList&, const std::vector >&, const std::vector >&, std::vector*, tensorflow::RunMetadata*)':
/build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_1_X_2018-02-17-1100/src/PhysicsTools/TensorFlow/src/TBBSession.cc:360:3: error: 'direct_session_runs' was not declared in this scope
   direct_session_runs->GetCell()->IncrementBy(1);
   ^~~~~~~~~~~~~~~~~~~
>> Compiling edm plugin /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_1_X_2018-02-17-1100/src/PhysicsTools/HepMCCandAlgos/plugins/GenParticleDecaySelector.cc 
>> Compiling edm plugin /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_1_X_2018-02-17-1100/src/PhysicsTools/HepMCCandAlgos/plugins/GenParticleSelector.cc 
>> Compiling edm plugin /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_1_X_2018-02-17-1100/src/PhysicsTools/HepMCCandAlgos/plugins/MCTruthMatchers.cc 


@cmsbuild
Copy link
Contributor

Comparison not run due to Build errors (RelVals and Igprof tests were also skipped)

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 18, 2018

The tests are being triggered in jenkins.
Using cmssw from cms-sw/cmssw#22260
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/26151/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 22, 2018

The tests are being triggered in jenkins.
Using cmssw from cms-sw/cmssw#22260
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/26247/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 2, 2018

The tests are being triggered in jenkins.
Using cmssw from cms-sw/cmssw#22260
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/26445/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 2, 2018

-1

Tested at: 574155f

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22260/26445/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests

  • Unit Tests:

I found errors in the following unit tests:

---> test testhep_ml had ERRORS
---> test testImports had ERRORS

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 2, 2018

Comparison job queued.

@smuzaffar
Copy link
Contributor Author

unit test failing here are not due to this PR. These failures are due to few python packages updated in externals.

@fabiocos
Copy link
Contributor

fabiocos commented Mar 5, 2018

+1

@fabiocos
Copy link
Contributor

fabiocos commented Mar 5, 2018

merge

@cmsbuild cmsbuild merged commit e688e09 into cms-sw:IB/CMSSW_10_1_X/gcc630 Mar 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants