Python3 spec file #3788
Python3 spec file #3788
Conversation
|
A new Pull Request was created by @davidlange6 (David Lange) for branch IB/CMSSW_10_1_X/gcc630. @cmsbuild, @smuzaffar, @gudrutis, @mrodozov can you please review it and eventually sign? Thanks. |
|
please test |
|
The tests are being triggered in jenkins. |
|
(most of cmssw-tool-conf is rebuild in my area by now-so the test should be ok) - i would propose to merge both sets of python changes before the 2300 tonight |
python3.spec
Outdated
| echo "if 'PYTHON3PATH' in environ:" >> %i/lib/python%{pythonv}/sitecustomize.py | ||
| echo " import sys,site" >> %i/lib/python%{pythonv}/sitecustomize.py | ||
| echo " for p in environ['PYTHON3PATH'].split(':'):">> %i/lib/python%{pythonv}/sitecustomize.py | ||
| echo " site.addsitedir(p)" >> %i/lib/python%{pythonv}/sitecustomize.py |
There was a problem hiding this comment.
should we change this logic to something like
from os import environ
if 'PYTHON3PATH' in environ:
import sys
sys.path =environ['PYTHON3PATH'].split(':') + sys.path
this way without any changes in SCRAM or buildrules (to dump .pth files) we can just update toolfiles to replace PYTHONPATH with PYTHON3PATH
|
Pull request #3788 was updated. |
|
please test |
|
The tests are being triggered in jenkins. |
|
-1 Tested at: 6e85532 You can see the results of the tests here: I found follow errors while testing this PR Failed tests: Build
I found an error when building: >> Compiling /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_1_X_2018-03-01-2300/src/DataFormats/Scalers/src/DcsStatus.cc Entering library rule at DataFormats/EcalRawData >> Building LCG reflex dict from header file src/DataFormats/EcalRawData/src/classes.h >> Compiling LCG dictionary: tmp/slc6_amd64_gcc630/src/CondFormats/Luminosity/src/CondFormatsLuminosity/a/CondFormatsLuminosity_xr.cc >> Compiling tmp/slc6_amd64_gcc630/src/CondFormats/Luminosity/src/CondFormatsLuminosity/a/Serialization.cc c++: error: tmp/slc6_amd64_gcc630/src/CondFormats/Luminosity/src/CondFormatsLuminosity/a/Serialization.cc: No such file or directory c++: fatal error: no input files compilation terminated. c++: error: tmp/slc6_amd64_gcc630/src/CondFormats/Luminosity/src/CondFormatsLuminosity/a/Serialization.cc: No such file or directory c++: fatal error: no input files compilation terminated. |
|
Comparison not run due to Build errors (RelVals and Igprof tests were also skipped) |
Thanks to @smuzaffar for a working python3 spec.
in addition, we've added a PYTHON27PATH variable to eventually remove our usage of PYTHONPATH (so possible to support python2 and 3 for some period)