New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python package updates / addition of lz4 #4103
Conversation
A new Pull Request was created by @davidlange6 (David Lange) for branch IB/CMSSW_10_2_X/gcc630. @cmsbuild, @smuzaffar, @gudrutis, @mrodozov can you please review it and eventually sign? Thanks. |
The tests are being triggered in jenkins. |
lz4-toolfile.spec
Outdated
%build | ||
%install | ||
mkdir -p %i/etc/scram.d | ||
cat << \EOF_TOOLFILE > %i/etc/scram.d/xz.xml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@davidlange6 , why tool name is xz and not lz4?
Pull request #4103 was updated. |
hi @smuzaffar - thanks for noticing - its a mistake |
please test |
The tests are being triggered in jenkins. |
Pull request #4103 was updated. |
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
@davidlange6 , can you please check the comparison results? |
please test |
The tests are being triggered in jenkins. |
+1 |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
@davidlange6 , can you please check the comparison for lz4 again. It again shows 25 errors. |
I notice the same sort of failures in #23545 - so I'd conclude its a new code bug in cmssw rather than this PR. |
+externals |
This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_10_2_X/gcc630 IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
adding lz4 instead of picking up from inside of root
adding python interfaces to lz4 and lzma
updating to latest version of a number of python packages