The Atlas GccCheckerPlugins package as an external. #4190

gartung · 2018-07-16T17:06:10Z

Although the PR is based on the gcc7 branch it can be back ported to any branch with a compiler that supports plugins and c++11.

cmsbuild · 2018-07-16T17:06:29Z

A new Pull Request was created by @gartung (Patrick Gartung) for branch IB/CMSSW_10_2_X/gcc700.

@cmsbuild, @smuzaffar, @gudrutis, @mrodozov can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

gartung · 2018-07-16T17:06:36Z

@smuzaffar @Dr15Jones

cmsbuild · 2018-07-16T17:21:43Z

Pull request #4190 was updated.

gartung · 2018-07-16T18:48:31Z

@smuzaffar

When I try to run the plugin as compiled is fails with

cc1plus: error: cannot load plugin /home/gartung/cms-build/slc7_amd64_gcc700/external/gcc-checker-plugin/1.0-cms2/lib/libchecker_gccplugins.so
/home/gartung/cms-build/slc7_amd64_gcc700/external/gcc-checker-plugin/1.0-cms2/lib/libchecker_gccplugins.so: undefined symbol: Z19get_inner_referenceP9tree_nodePlS1_PS0_P12machine_modePiS5_S5

If I link the plugin against libcp1plugin.so, it fails with

cc1plus: error: cannot load plugin /home/gartung/cms-build/slc7_amd64_gcc700/external/gcc-checker-plugin/1.0-cms/lib/libchecker_gccplugins.so
/home/gartung/CMSSW_10_2_0/external/slc7_amd64_gcc630/lib/libcp1plugin.so.0: undefined symbol: cp_binding_oracle

If I link the plugin against libcc1plugin.so, it fails with

cc1plus: error: cannot load plugin /home/gartung/cms-build/slc7_amd64_gcc700/external/gcc-checker-plugin/1.0-cms4/lib/libchecker_gccplugins.so
/home/gartung/CMSSW_10_2_0/external/slc7_amd64_gcc630/lib/libcc1plugin.so.0: undefined symbol: c_binding_oracle

gartung · 2018-07-16T19:33:07Z

Nevermind. I was able to determine that set up a project area for gcc630 and I compiled the plugin with gcc700.

gartung · 2018-07-16T19:45:20Z

Once the gcc-checker-plugin toolfile is configure in a project area the gcc checker can be run with

g++ -c -o /dev/null --std=c++14 -fplugin=$GCC_CHECKER_PLUGIN -fplugin-arg-libchecker_gccplugins-checkers=all $file

gartung · 2018-07-16T21:35:25Z

@Dr15Jones I took the twiki text from your email and reformatted it.
https://twiki.cern.ch/twiki/bin/view/Sandbox/PatrickGartungSandbox

gartung · 2018-07-17T22:55:16Z

@davidlange6 Are you opposed to this one too?

davidlange6 · 2018-07-18T10:44:45Z

not specifically - presumably if we want this for more than a quick test, we should get it put into a proper distribution (add bonus, with a makefile or similar) rather than downloading all the root/fastjet etc etc etc sources that atlas uses..

smuzaffar · 2018-07-18T11:08:20Z

gcc-checker-plugin-toolfile.spec

+%post
+%{relocateConfig}etc/scram.d/*.xml
+echo "GCC_CHECKER_PLUGIN_TOOLFILE_ROOT='$CMS_INSTALL_PREFIX/%{pkgrel}'; export GCC_CHECKER_PLUGIN_TOOLFILE_ROOT" > $RPM_INSTALL_PREFIX/%{pkgrel}/etc/profile.d/init.sh
+echo "setenv GCC_CHECKER_PLUGIN_TOOLFILE_ROOT '$CMS_INSTALL_PREFIX/%{pkgrel}'" > $RPM_INSTALL_PREFIX/%{pkgrel}/etc/profile.d/init.csh


@gartung , I don't think you need all this logic in this spec file. Just copy the one e.g. curl-toolfile.spec and update variables.

Eventually you will need the path to the plugin library.

smuzaffar · 2018-07-18T11:09:25Z

gcc-checker-plugin.spec

@@ -0,0 +1,23 @@
+### RPM external gcc-checker-plugin 1.0


@gartung , use version 2.0.9 here and replace 2.0.9 with %{realversion} in rest of the file.

davidlange6 · 2018-07-18T11:12:43Z

the trouble is that 2.0.9 has nothing to do with the version number of this specific package being built..

…

On Jul 18, 2018, at 1:09 PM, Malik Shahzad Muzaffar ***@***.***> wrote: @smuzaffar commented on this pull request. In gcc-checker-plugin.spec: > @@ -0,0 +1,23 @@ +### RPM external gcc-checker-plugin 1.0 @gartung , use version 2.0.9 here and replace 2.0.9 with %{realversion} in rest of the file. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

smuzaffar · 2018-07-18T11:23:07Z

but at least it points to a tag in gitlab ... right?

davidlange6 · 2018-07-18T11:26:59Z

no. It seems to be a version of a tarball full of sources from many projects cd atlasexternals-2.0.9-671e8f2b1413ff87772ea5dc024abeb5ef6ee441 ls APE CheckerGccPlugins FastJetContrib HEPUtils MCUtils SoQt Acts Coin3D GPerfTools HepMCAnalysis MKL XRootD BAT Davix Gdb KLFitter PyAnalysis dSFMT Blas Eigen Geant4 Lapack Python dcap Boost FFTW GoogleTest Lhapdf ROOT lwtnn CLHEP FastJet HDF5 LibXml2 Simage yampl

…

On Jul 18, 2018, at 1:23 PM, Malik Shahzad Muzaffar ***@***.***> wrote: but at least it points to a tag in gitlab ... right? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

gartung · 2018-07-18T14:03:17Z

I created this PR for review. It should not be merged yet. I plan to create a repo under cms-externals with just CheckerGccPlugin. I also want to change the Altas references to CMS. Is there a way to mark this PR WIP or For Review. I would mark the codecompass PR the same way.

…he checker macros can include the header checker_macros.h.

cmsbuild · 2018-07-18T15:54:00Z

Pull request #4190 was updated.

gartung · 2018-07-18T16:03:23Z

I put the CheckerGccPlugins source in its own repository here
https://github.com/gartung/CheckerGccPlugins
I added a Makefile and changed all of the ATLAS references to CMS. This includes the checker_macros.h header that needs to be included to use the pragma macros needed to activate the thread checkers. The header could be placed in CMSSW if that is easier.

cmsbuild · 2018-07-19T15:32:04Z

Pull request #4190 was updated.

cmsbuild · 2018-07-19T17:06:07Z

Pull request #4190 was updated.

gartung · 2018-07-19T17:27:56Z

Mostly unmodified source now in cms-external repo
https://github.com/cms-externals/CheckerGccPlugins

…scram b COMPILER=gcc-analyzer

cmsbuild · 2018-07-20T20:03:26Z

Pull request #4190 was updated.

gartung · 2018-07-20T20:04:50Z

Create gcc-analyzer-c(xx)compiler.xml so gcc checker can be run with
scram b COMPILER=gcc-analyzer

smuzaffar · 2018-07-23T08:02:37Z

please test

cmsbuild · 2018-07-23T08:03:58Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/29320/console

- set type=compiler for gcc-analyzer-c*compiler - fix the name of analyzer tools - make use of scram-tools-post

cmsbuild · 2018-07-23T10:39:46Z

Pull request #4190 was updated.

smuzaffar · 2018-07-23T10:40:02Z

gcc-checker-plugin-toolfile.spec

+      <environment name="INCLUDE"   default="$GCC_CHECKER_PLUGIN_ROOT/include"/>
+    </client>
+  </tool>
+  <runtime name="GCC_CHECKER_PLUGIN" default="$GCC_CHECKER_PLUGIN_ROOT/lib/libchecker_gccplugins.so"/>


do we need GCC_CHECKER_PLUGIN env variable?

It is no longer needed.

smuzaffar · 2018-07-23T10:44:36Z

please test

cmsbuild · 2018-07-23T10:44:51Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/29328/console

cmsbuild · 2018-07-23T13:20:41Z

Pull request #4190 was updated.

cmsbuild · 2018-07-23T14:25:18Z

+1
Tested at: f24c477
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4190/29328/summary.html

cmsbuild · 2018-07-23T14:25:21Z

Comparison job queued.

cmsbuild · 2018-07-23T16:03:04Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4190/29328/summary.html

The workflows 1001.0, 1000.0, 140.53, 136.85, 136.8311, 136.7611, 136.731, 4.22 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 31
DQMHistoTests: Total histograms compared: 2889291
DQMHistoTests: Total failures: 7
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2889094
DQMHistoTests: Total skipped: 190
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 30 files compared)
Checked 128 log files, 14 edm output root files, 31 DQM output files

gartung added 2 commits July 12, 2018 17:39

Add gcc toolfile with location of gcc plugin headers and library

428c7b6

This adds the Atlas GccCheckerPlugins package as an external library.

a5cf605

cmsbuild added externals-pending orp-pending pending-signatures tests-pending labels Jul 16, 2018

Add GCC_CHECKER_PLUGIN var to runtime env

7571eba

gartung closed this Jul 17, 2018

gartung reopened this Jul 17, 2018

smuzaffar changed the base branch from IB/CMSSW_10_2_X/gcc700 to IB/CMSSW_10_3_X/gcc700 July 18, 2018 08:15

smuzaffar reviewed Jul 18, 2018

View reviewed changes

gartung added 2 commits July 18, 2018 10:47

Take CMS modified CheckerGccPlugins from newly created repo.

9052704

GccCheckerPlugin toolfile needs the include directory so file using t…

000e883

…he checker macros can include the header checker_macros.h.

Use cms-externals/GccCheckerPlugin repo.

7cf3af9

Bump version to use cmake build.

f862933

Create gcc-analyzer-c(xx)compiler.xml so gcc checker can be run with …

b3d1200

…scram b COMPILER=gcc-analyzer

cmsbuild added tests-started and removed tests-pending labels Jul 23, 2018

simplify toolfile

f24c477

- set type=compiler for gcc-analyzer-c*compiler - fix the name of analyzer tools - make use of scram-tools-post

cmsbuild added tests-pending and removed tests-started labels Jul 23, 2018

smuzaffar reviewed Jul 23, 2018

View reviewed changes

cmsbuild added tests-started and removed tests-pending labels Jul 23, 2018

drop GCC_CHECKER_PLUGIN env variable

afb063a

cmsbuild added tests-pending and removed tests-started labels Jul 23, 2018

smuzaffar merged commit e798df6 into cms-sw:IB/CMSSW_10_3_X/gcc700 Jul 23, 2018

gartung deleted the add-gcc-plugin-toolfile branch October 12, 2019 14:54

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

The Atlas GccCheckerPlugins package as an external. #4190

The Atlas GccCheckerPlugins package as an external. #4190

gartung commented Jul 16, 2018

cmsbuild commented Jul 16, 2018

gartung commented Jul 16, 2018

cmsbuild commented Jul 16, 2018

gartung commented Jul 16, 2018

gartung commented Jul 16, 2018

gartung commented Jul 16, 2018

gartung commented Jul 16, 2018

gartung commented Jul 17, 2018

davidlange6 commented Jul 18, 2018

smuzaffar Jul 18, 2018

gartung Jul 18, 2018

smuzaffar Jul 18, 2018

davidlange6 commented Jul 18, 2018 via email

smuzaffar commented Jul 18, 2018

davidlange6 commented Jul 18, 2018 via email

gartung commented Jul 18, 2018

cmsbuild commented Jul 18, 2018

gartung commented Jul 18, 2018

cmsbuild commented Jul 19, 2018

cmsbuild commented Jul 19, 2018

gartung commented Jul 19, 2018 •

edited

cmsbuild commented Jul 20, 2018

gartung commented Jul 20, 2018

smuzaffar commented Jul 23, 2018

cmsbuild commented Jul 23, 2018 •

edited

cmsbuild commented Jul 23, 2018

smuzaffar Jul 23, 2018

gartung Jul 23, 2018

smuzaffar commented Jul 23, 2018

cmsbuild commented Jul 23, 2018 •

edited

cmsbuild commented Jul 23, 2018

cmsbuild commented Jul 23, 2018

cmsbuild commented Jul 23, 2018

cmsbuild commented Jul 23, 2018

The Atlas GccCheckerPlugins package as an external. #4190

The Atlas GccCheckerPlugins package as an external. #4190

Conversation

gartung commented Jul 16, 2018

cmsbuild commented Jul 16, 2018

gartung commented Jul 16, 2018

cmsbuild commented Jul 16, 2018

gartung commented Jul 16, 2018

gartung commented Jul 16, 2018

gartung commented Jul 16, 2018

gartung commented Jul 16, 2018

gartung commented Jul 17, 2018

davidlange6 commented Jul 18, 2018

smuzaffar Jul 18, 2018

Choose a reason for hiding this comment

gartung Jul 18, 2018

Choose a reason for hiding this comment

smuzaffar Jul 18, 2018

Choose a reason for hiding this comment

davidlange6 commented Jul 18, 2018 via email

smuzaffar commented Jul 18, 2018

davidlange6 commented Jul 18, 2018 via email

gartung commented Jul 18, 2018

cmsbuild commented Jul 18, 2018

gartung commented Jul 18, 2018

cmsbuild commented Jul 19, 2018

cmsbuild commented Jul 19, 2018

gartung commented Jul 19, 2018 • edited

cmsbuild commented Jul 20, 2018

gartung commented Jul 20, 2018

smuzaffar commented Jul 23, 2018

cmsbuild commented Jul 23, 2018 • edited

cmsbuild commented Jul 23, 2018

smuzaffar Jul 23, 2018

Choose a reason for hiding this comment

gartung Jul 23, 2018

Choose a reason for hiding this comment

smuzaffar commented Jul 23, 2018

cmsbuild commented Jul 23, 2018 • edited

cmsbuild commented Jul 23, 2018

cmsbuild commented Jul 23, 2018

cmsbuild commented Jul 23, 2018

cmsbuild commented Jul 23, 2018

gartung commented Jul 19, 2018 •

edited

cmsbuild commented Jul 23, 2018 •

edited

cmsbuild commented Jul 23, 2018 •

edited