Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

suppress usage of AVX instructions in mxnet (102X version of #4194) #4198

Merged
merged 1 commit into from Jul 21, 2018

Conversation

slava77
Copy link
Contributor

@slava77 slava77 commented Jul 19, 2018

this is a 10_2_X version of #4194

a copy of that PR description follows

I was testing cms-sw/cmssw#23768 on non-AVX machine and saw crashes due to invalid instructions.
In the specific case, it was a call to vpxor in mxnet::op::AdaptiveAvgPoolParam::__MANAGER__() ().
After recompiling with USE_F16C=0, the same place in the code is using a simple pxor.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @slava77 (Slava Krutelyov) for branch IB/CMSSW_10_2_X/gcc630.

@cmsbuild, @smuzaffar, @gudrutis, @mrodozov can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@slava77
Copy link
Contributor Author

slava77 commented Jul 19, 2018

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 20, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/29275/console

@smuzaffar smuzaffar changed the base branch from IB/CMSSW_10_2_X/gcc630 to IB/CMSSW_10_2_X/gcc700 July 20, 2018 23:01
@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4198/29275/summary.html

The workflows 1001.0, 1000.0, 140.53, 136.85, 136.8311, 136.7611, 136.731, 4.22 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 31
  • DQMHistoTests: Total histograms compared: 2892290
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2892099
  • DQMHistoTests: Total skipped: 190
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 30 files compared)
  • Checked 128 log files, 14 edm output root files, 31 DQM output files

@smuzaffar
Copy link
Contributor

+extenals

@smuzaffar smuzaffar merged commit 122444e into cms-sw:IB/CMSSW_10_2_X/gcc700 Jul 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants