Update RecoEgamma-PhotonIdentification to 01-00-06 #4230
Conversation
|
please test |
|
The tests are being triggered in jenkins. |
|
A new Pull Request was created by @mrodozov (Mircho Rodozov) for branch IB/CMSSW_10_3_X/gcc700. @cmsbuild, @smuzaffar, @gudrutis, @mrodozov can you please review it and eventually sign? Thanks. |
|
about " please test" IIUC, these tests are expected to fail. we still need a PR in CMSSW to adjust to the file renamings |
|
abort |
|
lets restart it when we have the cmssw pr then |
|
Jenkins tests are aborted. |
|
@guitargeek please clarify on the status of the CMSSW PR. |
|
It's ready, but Egamma is waiting for the one who trained the photon ID to validate the MVA output. What I can do myself is to get rid of the new ID in the PR, and we do a PR for the new weight files structure plus some other improvements and bug fixes in PhotonIdentification. Later, when I fnally get the egamma green light, I could follow up with the ID config file and the inclusion in Mini/NanoAOD. |
|
On 7/30/18 6:58 AM, Jonas Rembser wrote:
It's ready, but Egamma is waiting for the one who trained the photon ID
to validate the MVA output.
What I can do myself is to get rid of the new ID in the PR, and we do a
PR for the new weight files structure plus some other improvements and
bug fixes in PhotonIdentification. Later, when I fnally get the egamma
green light, I could follow up with the ID config file and the inclusion
in Mini/NanoAOD.
this sounds like a good plan.
Let's go ahead with this.
|
|
Okay! I set up a PR which implements the plan here: cms-sw/cmssw#24131 |
|
The tests are being triggered in jenkins. |
|
Comparison job queued. |
|
The tests are being triggered in jenkins. |
|
Comparison job queued. |
|
The tests are being triggered in jenkins. |
|
Comparison job queued. |
|
+1 |
|
merge |
Description: cms-data/RecoEgamma-PhotonIdentification#7